Re: [Intel-gfx] [PATCH 05/15] drm/i915: Drop schedule_back from psr_exit

2014-06-17 Thread Daniel Vetter
On Mon, Jun 16, 2014 at 05:06:06PM -0700, Rodrigo Vivi wrote: > There were more reasons for disabling it on Baytrail... but you are right.. > disable sequence should be better for those cases. > > Reviewed-by: Rodrigo Vivi Well I should mention that later on we'll split this into psr_invalidate

Re: [Intel-gfx] [PATCH 05/15] drm/i915: Drop schedule_back from psr_exit

2014-06-16 Thread Rodrigo Vivi
There were more reasons for disabling it on Baytrail... but you are right.. disable sequence should be better for those cases. Reviewed-by: Rodrigo Vivi On Mon, Jun 16, 2014 at 10:51 AM, Daniel Vetter wrote: > It doesn't make sense to never again schedule the work, since by the > time we migh

[Intel-gfx] [PATCH 05/15] drm/i915: Drop schedule_back from psr_exit

2014-06-16 Thread Daniel Vetter
It doesn't make sense to never again schedule the work, since by the time we might want to re-enable psr the world might have changed and we can do it again. The only exception is when we shut down the pipe, but that's an entirely different thing and needs to be handled in psr_disable. Cc: Rodrig