Re: [Intel-gfx] [PATCH 04/33] drm/i915: Compute the HWS offsets explicitly

2019-01-25 Thread Mika Kuoppala
Chris Wilson writes: > Simplify by using sizeof(u32) to convert from the index inside the HWSP > to the byte offset. This has the advantage of not only being shorter > (and so not upsetting checkpatch!) but that it matches use where we are > writing to byte addresses using other commands than MI_

[Intel-gfx] [PATCH 04/33] drm/i915: Compute the HWS offsets explicitly

2019-01-24 Thread Chris Wilson
Simplify by using sizeof(u32) to convert from the index inside the HWSP to the byte offset. This has the advantage of not only being shorter (and so not upsetting checkpatch!) but that it matches use where we are writing to byte addresses using other commands than MI_STORE_DWORD_IMM. Signed-off-by