Re: [Intel-gfx] [PATCH 04/18] drm/i915: add context information to objects

2012-03-29 Thread Ben Widawsky
On Thu, 29 Mar 2012 10:47:56 +0200 Daniel Vetter wrote: > On Wed, Mar 28, 2012 at 05:20:11PM -0700, Ben Widawsky wrote: > > On Thu, 29 Mar 2012 00:36:21 +0200 > > Daniel Vetter wrote: > > > > > On Sun, Mar 18, 2012 at 01:39:44PM -0700, Ben Widawsky wrote: > > > > Handy mostly for assertions. >

Re: [Intel-gfx] [PATCH 04/18] drm/i915: add context information to objects

2012-03-29 Thread Daniel Vetter
On Wed, Mar 28, 2012 at 05:20:11PM -0700, Ben Widawsky wrote: > On Thu, 29 Mar 2012 00:36:21 +0200 > Daniel Vetter wrote: > > > On Sun, Mar 18, 2012 at 01:39:44PM -0700, Ben Widawsky wrote: > > > Handy mostly for assertions. > > > > > > Signed-off-by: Ben Widawsky > > > > I don't see the point

Re: [Intel-gfx] [PATCH 04/18] drm/i915: add context information to objects

2012-03-28 Thread Ben Widawsky
On Thu, 29 Mar 2012 00:36:21 +0200 Daniel Vetter wrote: > On Sun, Mar 18, 2012 at 01:39:44PM -0700, Ben Widawsky wrote: > > Handy mostly for assertions. > > > > Signed-off-by: Ben Widawsky > > I don't see the point of carrying around a obj->context_id - > context_id's are file_priv, so they're

Re: [Intel-gfx] [PATCH 04/18] drm/i915: add context information to objects

2012-03-28 Thread Daniel Vetter
On Sun, Mar 18, 2012 at 01:39:44PM -0700, Ben Widawsky wrote: > Handy mostly for assertions. > > Signed-off-by: Ben Widawsky I don't see the point of carrying around a obj->context_id - context_id's are file_priv, so they're not that useful in the tracepoint. I suggest you just drop the contex_i

[Intel-gfx] [PATCH 04/18] drm/i915: add context information to objects

2012-03-18 Thread Ben Widawsky
Handy mostly for assertions. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_drv.h |5 + drivers/gpu/drm/i915/i915_gem.c |1 + drivers/gpu/drm/i915/i915_gem_context.c |3 +++ 3 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h