Re: [Intel-gfx] [PATCH 04/13] drm/i915: track ring progression using seqnos

2013-02-26 Thread Chris Wilson
On Tue, Feb 26, 2013 at 05:09:03PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Tue, Feb 26, 2013 at 01:05:07PM +0200, Mika Kuoppala wrote: > >> Instead of relying in acthd, track ring seqno progression > >> to detect if ring has hung. > > > > This needs a comment that it has a use

Re: [Intel-gfx] [PATCH 04/13] drm/i915: track ring progression using seqnos

2013-02-26 Thread Mika Kuoppala
Chris Wilson writes: > On Tue, Feb 26, 2013 at 01:05:07PM +0200, Mika Kuoppala wrote: >> Instead of relying in acthd, track ring seqno progression >> to detect if ring has hung. > > This needs a comment that it has a user visible side-effect of limiting > batches to a maximum of 1.5s runtime. Bef

Re: [Intel-gfx] [PATCH 04/13] drm/i915: track ring progression using seqnos

2013-02-26 Thread Chris Wilson
On Tue, Feb 26, 2013 at 01:05:07PM +0200, Mika Kuoppala wrote: > Instead of relying in acthd, track ring seqno progression > to detect if ring has hung. This needs a comment that it has a user visible side-effect of limiting batches to a maximum of 1.5s runtime. Before, that limit was softer in th

[Intel-gfx] [PATCH 04/13] drm/i915: track ring progression using seqnos

2013-02-26 Thread Mika Kuoppala
Instead of relying in acthd, track ring seqno progression to detect if ring has hung. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h |2 -- drivers/gpu/drm/i915/i915_irq.c | 30 +- drivers/gpu/drm/i915/intel_ringbuffer.h |2