Re: [Intel-gfx] [PATCH 04/13] drm/i915/cnp: Backlight support for CNP.

2017-06-02 Thread Jani Nikula
CNP. Ack. We can also clarify/unify the definitions later on as needed. BR, Jani. > > -DK > > -Original Message- > From: Vivi, Rodrigo > Sent: Thursday, June 1, 2017 9:29 AM > To: Pandiyan, Dhinakaran > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani > Su

Re: [Intel-gfx] [PATCH 04/13] drm/i915/cnp: Backlight support for CNP.

2017-06-01 Thread Pandiyan, Dhinakaran
, 2017 9:29 AM To: Pandiyan, Dhinakaran Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani Subject: Re: [Intel-gfx] [PATCH 04/13] drm/i915/cnp: Backlight support for CNP. On Thu, 2017-06-01 at 02:15 +, Pandiyan, Dhinakaran wrote: > On Tue, 2017-05-30 at 15:42 -0700, Rodrigo Vivi wrote: > &

Re: [Intel-gfx] [PATCH 04/13] drm/i915/cnp: Backlight support for CNP.

2017-06-01 Thread Vivi, Rodrigo
On Thu, 2017-06-01 at 02:15 +, Pandiyan, Dhinakaran wrote: > On Tue, 2017-05-30 at 15:42 -0700, Rodrigo Vivi wrote: > > Split out BXT and CNP's setup_backlight(),enable_backlight(), > > disable_backlight() and hz_to_pwm() into > > two separate functions instead of reusing BXT function. > > > >

Re: [Intel-gfx] [PATCH 04/13] drm/i915/cnp: Backlight support for CNP.

2017-05-31 Thread Pandiyan, Dhinakaran
On Tue, 2017-05-30 at 15:42 -0700, Rodrigo Vivi wrote: > Split out BXT and CNP's setup_backlight(),enable_backlight(), > disable_backlight() and hz_to_pwm() into > two separate functions instead of reusing BXT function. > > Reuse set_backlight() and get_backlight() since they have > no reference t

[Intel-gfx] [PATCH 04/13] drm/i915/cnp: Backlight support for CNP.

2017-05-30 Thread Rodrigo Vivi
Split out BXT and CNP's setup_backlight(),enable_backlight(), disable_backlight() and hz_to_pwm() into two separate functions instead of reusing BXT function. Reuse set_backlight() and get_backlight() since they have no reference to the utility pin. v2: Reuse BXT functions with controller 0 inste