Re: [Intel-gfx] [PATCH 04/10] drm/i915: drop polled waits from i915_wait_request

2012-04-21 Thread Ben Widawsky
On Sat, 21 Apr 2012 10:29:35 +0100 Chris Wilson wrote: > On Fri, 20 Apr 2012 18:23:26 -0700, Ben Widawsky > wrote: > > The only time irq_get should fail is during unload or suspend. Both > > of these points should try to quiesce the GPU before disabling > > interrupts and so the atomic polling s

Re: [Intel-gfx] [PATCH 04/10] drm/i915: drop polled waits from i915_wait_request

2012-04-21 Thread Chris Wilson
On Fri, 20 Apr 2012 18:23:26 -0700, Ben Widawsky wrote: > The only time irq_get should fail is during unload or suspend. Both of > these points should try to quiesce the GPU before disabling interrupts > and so the atomic polling should never occur. > > This was recommended by Chris Wilson as a w

[Intel-gfx] [PATCH 04/10] drm/i915: drop polled waits from i915_wait_request

2012-04-20 Thread Ben Widawsky
The only time irq_get should fail is during unload or suspend. Both of these points should try to quiesce the GPU before disabling interrupts and so the atomic polling should never occur. This was recommended by Chris Wilson as a way of reducing added complexity to the polled wait which I introduc