Re: [Intel-gfx] [PATCH 03/24] drm/i915: clean up intel_sanitize_crtc

2015-06-02 Thread Maarten Lankhorst
Op 03-06-15 om 03:27 schreef Matt Roper: > On Mon, Jun 01, 2015 at 03:27:06PM +0200, Maarten Lankhorst wrote: >> Apply force if needed. > It's not clear to me what this means; can you elaborate? It seems that > 'force' in the context of intel_crtc_control() means we're updating the > 'enable' fiel

Re: [Intel-gfx] [PATCH 03/24] drm/i915: clean up intel_sanitize_crtc

2015-06-02 Thread Matt Roper
On Mon, Jun 01, 2015 at 03:27:06PM +0200, Maarten Lankhorst wrote: > Apply force if needed. It's not clear to me what this means; can you elaborate? It seems that 'force' in the context of intel_crtc_control() means we're updating the 'enable' field as well, not just the 'active' field. > During

[Intel-gfx] [PATCH 03/24] drm/i915: clean up intel_sanitize_crtc

2015-06-01 Thread Maarten Lankhorst
Apply force if needed. During boot pipe_config->active will be false. On resume no separate modeset is needed when the state gets restored with the sw state anyway. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_debugfs.c | 8 ++-- drivers/gpu/drm/i915/intel_display.c | 84