Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

2016-10-07 Thread Joonas Lahtinen
On to, 2016-10-06 at 08:37 +0100, Tvrtko Ursulin wrote: > On 06/10/2016 07:58, Joonas Lahtinen wrote: > > I rather meant how did you deduce the right datatype sizes? > > > > Oh right, I've looked at the values stored in them and got extra  > confidence when the compiler did not complain. The cod

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

2016-10-06 Thread Ville Syrjälä
On Thu, Oct 06, 2016 at 05:38:12PM +0100, Tvrtko Ursulin wrote: > > On 05/10/2016 18:11, Ville Syrjälä wrote: > > On Wed, Oct 05, 2016 at 01:33:30PM +0100, Tvrtko Ursulin wrote: > >> From: Tvrtko Ursulin > >> > >> Use types of more appropriate size in struct > >> intel_watermark_params to save 51

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

2016-10-06 Thread Tvrtko Ursulin
On 05/10/2016 18:11, Ville Syrjälä wrote: On Wed, Oct 05, 2016 at 01:33:30PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use types of more appropriate size in struct intel_watermark_params to save 512 bytes of .rodata. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_drv

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

2016-10-06 Thread Tvrtko Ursulin
On 06/10/2016 07:58, Joonas Lahtinen wrote: On ke, 2016-10-05 at 17:53 +0100, Tvrtko Ursulin wrote: On 05/10/2016 17:50, Tvrtko Ursulin wrote: On 05/10/2016 16:07, Joonas Lahtinen wrote: On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use types of more appropr

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

2016-10-05 Thread Joonas Lahtinen
On ke, 2016-10-05 at 17:53 +0100, Tvrtko Ursulin wrote: > On 05/10/2016 17:50, Tvrtko Ursulin wrote: > > > > > > On 05/10/2016 16:07, Joonas Lahtinen wrote: > > > > > > On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote: > > > > > > > > From: Tvrtko Ursulin > > > > > > > > Use types of mo

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

2016-10-05 Thread Ville Syrjälä
On Wed, Oct 05, 2016 at 01:33:30PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Use types of more appropriate size in struct > intel_watermark_params to save 512 bytes of .rodata. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/intel_drv.h | 10 +- > drivers/g

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

2016-10-05 Thread Tvrtko Ursulin
On 05/10/2016 17:50, Tvrtko Ursulin wrote: On 05/10/2016 16:07, Joonas Lahtinen wrote: On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use types of more appropriate size in struct intel_watermark_params to save 512 bytes of .rodata. Signed-off-by: Tvrtko Ursuli

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

2016-10-05 Thread Tvrtko Ursulin
On 05/10/2016 16:07, Joonas Lahtinen wrote: On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use types of more appropriate size in struct intel_watermark_params to save 512 bytes of .rodata. Signed-off-by: Tvrtko Ursulin The code does seem to use datatypes very

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

2016-10-05 Thread Joonas Lahtinen
On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Use types of more appropriate size in struct > intel_watermark_params to save 512 bytes of .rodata. > > Signed-off-by: Tvrtko Ursulin The code does seem to use datatypes very sloppily. Where did you pick up thes

[Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

2016-10-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use types of more appropriate size in struct intel_watermark_params to save 512 bytes of .rodata. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_drv.h | 10 +- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-