Re: [Intel-gfx] [PATCH 03/20] drm/i915: use GEN8_IRQ_INIT on GEN5

2014-03-27 Thread Paulo Zanoni
2014-03-26 18:37 GMT-03:00 Daniel Vetter : > On Wed, Mar 26, 2014 at 9:00 PM, Paulo Zanoni wrote: >> Anyway, we have discussed this and it seems everybody prefers to have >> the POSTING_READ calls on the macro, so I'll just change the patches >> to do this, and then the comment will disappear. > >

Re: [Intel-gfx] [PATCH 03/20] drm/i915: use GEN8_IRQ_INIT on GEN5

2014-03-26 Thread Daniel Vetter
On Wed, Mar 26, 2014 at 9:00 PM, Paulo Zanoni wrote: > Anyway, we have discussed this and it seems everybody prefers to have > the POSTING_READ calls on the macro, so I'll just change the patches > to do this, and then the comment will disappear. I think for consistency we should do the same chan

Re: [Intel-gfx] [PATCH 03/20] drm/i915: use GEN8_IRQ_INIT on GEN5

2014-03-26 Thread Paulo Zanoni
2014-03-18 14:11 GMT-03:00 Ben Widawsky : > On Fri, Mar 07, 2014 at 08:10:19PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> And rename is to GEN5_IRQ_INIT. >> >> We have discussed doing equivalent changes on July 2013, and I even >> sent a patch series for this: "[PATCH 00/15] Unify inte

Re: [Intel-gfx] [PATCH 03/20] drm/i915: use GEN8_IRQ_INIT on GEN5

2014-03-18 Thread Daniel Vetter
On Tue, Mar 18, 2014 at 10:11:38AM -0700, Ben Widawsky wrote: > On Fri, Mar 07, 2014 at 08:10:19PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > And rename is to GEN5_IRQ_INIT. > > > > We have discussed doing equivalent changes on July 2013, and I even > > sent a patch series for thi

Re: [Intel-gfx] [PATCH 03/20] drm/i915: use GEN8_IRQ_INIT on GEN5

2014-03-18 Thread Ben Widawsky
On Fri, Mar 07, 2014 at 08:10:19PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > And rename is to GEN5_IRQ_INIT. > > We have discussed doing equivalent changes on July 2013, and I even > sent a patch series for this: "[PATCH 00/15] Unify interrupt register > init/reset". Now that the BDW c

[Intel-gfx] [PATCH 03/20] drm/i915: use GEN8_IRQ_INIT on GEN5

2014-03-07 Thread Paulo Zanoni
From: Paulo Zanoni And rename is to GEN5_IRQ_INIT. We have discussed doing equivalent changes on July 2013, and I even sent a patch series for this: "[PATCH 00/15] Unify interrupt register init/reset". Now that the BDW code was merged, I have one more argument in favor of these changes. Here's