Re: [Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-03-18 Thread Chris Wilson
On Tue, Mar 18, 2014 at 07:38:43PM -0700, Ben Widawsky wrote: > On Tue, Mar 18, 2014 at 06:27:03PM -0700, Ben Widawsky wrote: > > On Sat, Feb 22, 2014 at 01:37:16PM +, Chris Wilson wrote: > > > On Mon, Feb 17, 2014 at 07:01:44PM -0800, Ben Widawsky wrote: > > > > The names of the struct members

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-03-18 Thread Ben Widawsky
On Tue, Mar 18, 2014 at 06:27:03PM -0700, Ben Widawsky wrote: > On Sat, Feb 22, 2014 at 01:37:16PM +, Chris Wilson wrote: > > On Mon, Feb 17, 2014 at 07:01:44PM -0800, Ben Widawsky wrote: > > > The names of the struct members for RPS are stupid. Every time I need to > > > do anything in this co

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-03-18 Thread Ben Widawsky
On Sat, Feb 22, 2014 at 01:37:16PM +, Chris Wilson wrote: > On Mon, Feb 17, 2014 at 07:01:44PM -0800, Ben Widawsky wrote: > > The names of the struct members for RPS are stupid. Every time I need to > > do anything in this code I have to spend a significant amount of time to > > remember what i

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-02-24 Thread Ben Widawsky
On Sat, Feb 22, 2014 at 08:08:23PM +, Chris Wilson wrote: > On Sat, Feb 22, 2014 at 11:40:43AM -0800, Ben Widawsky wrote: > > On Sat, Feb 22, 2014 at 07:37:04PM +, Chris Wilson wrote: > > > On Sat, Feb 22, 2014 at 11:34:16AM -0800, Ben Widawsky wrote: > > > > On Sat, Feb 22, 2014 at 01:37:1

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-02-22 Thread Chris Wilson
On Sat, Feb 22, 2014 at 11:38:55AM -0800, Ben Widawsky wrote: > On Sat, Feb 22, 2014 at 11:34:16AM -0800, Ben Widawsky wrote: > > On Sat, Feb 22, 2014 at 01:37:16PM +, Chris Wilson wrote: > > > On Mon, Feb 17, 2014 at 07:01:44PM -0800, Ben Widawsky wrote: > > > > The names of the struct members

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-02-22 Thread Chris Wilson
On Sat, Feb 22, 2014 at 11:40:43AM -0800, Ben Widawsky wrote: > On Sat, Feb 22, 2014 at 07:37:04PM +, Chris Wilson wrote: > > On Sat, Feb 22, 2014 at 11:34:16AM -0800, Ben Widawsky wrote: > > > On Sat, Feb 22, 2014 at 01:37:16PM +, Chris Wilson wrote: > > > > On Mon, Feb 17, 2014 at 07:01:4

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-02-22 Thread Ben Widawsky
On Sat, Feb 22, 2014 at 07:37:04PM +, Chris Wilson wrote: > On Sat, Feb 22, 2014 at 11:34:16AM -0800, Ben Widawsky wrote: > > On Sat, Feb 22, 2014 at 01:37:16PM +, Chris Wilson wrote: > > > On Mon, Feb 17, 2014 at 07:01:44PM -0800, Ben Widawsky wrote: > > > > The names of the struct members

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-02-22 Thread Ben Widawsky
On Sat, Feb 22, 2014 at 11:34:16AM -0800, Ben Widawsky wrote: > On Sat, Feb 22, 2014 at 01:37:16PM +, Chris Wilson wrote: > > On Mon, Feb 17, 2014 at 07:01:44PM -0800, Ben Widawsky wrote: > > > The names of the struct members for RPS are stupid. Every time I need to > > > do anything in this co

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-02-22 Thread Chris Wilson
On Sat, Feb 22, 2014 at 11:34:16AM -0800, Ben Widawsky wrote: > On Sat, Feb 22, 2014 at 01:37:16PM +, Chris Wilson wrote: > > On Mon, Feb 17, 2014 at 07:01:44PM -0800, Ben Widawsky wrote: > > > The names of the struct members for RPS are stupid. Every time I need to > > > do anything in this co

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-02-22 Thread Ben Widawsky
On Sat, Feb 22, 2014 at 01:37:16PM +, Chris Wilson wrote: > On Mon, Feb 17, 2014 at 07:01:44PM -0800, Ben Widawsky wrote: > > The names of the struct members for RPS are stupid. Every time I need to > > do anything in this code I have to spend a significant amount of time to > > remember what i

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-02-22 Thread Chris Wilson
On Mon, Feb 17, 2014 at 07:01:44PM -0800, Ben Widawsky wrote: > The names of the struct members for RPS are stupid. Every time I need to > do anything in this code I have to spend a significant amount of time to > remember what it all means. By renaming the variables (and adding the > comments) I h

[Intel-gfx] [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff*

2014-02-17 Thread Ben Widawsky
The names of the struct members for RPS are stupid. Every time I need to do anything in this code I have to spend a significant amount of time to remember what it all means. By renaming the variables (and adding the comments) I hope to clear up the situation. Indeed doing this make some upcoming pa