Re: [Intel-gfx] [PATCH 03/10] drm/armada: Drop fb gamma_set/get functions

2016-03-30 Thread Daniel Vetter
On Wed, Mar 30, 2016 at 01:56:06PM +0100, Russell King - ARM Linux wrote: > On Wed, Mar 30, 2016 at 01:19:21PM +0200, Daniel Vetter wrote: > > On Wed, Mar 30, 2016 at 1:09 PM, Russell King - ARM Linux > > wrote: > > > On Wed, Mar 30, 2016 at 11:51:18AM +0200, Daniel Vetter wrote: > > >> The fb hel

Re: [Intel-gfx] [PATCH 03/10] drm/armada: Drop fb gamma_set/get functions

2016-03-30 Thread Russell King - ARM Linux
On Wed, Mar 30, 2016 at 01:19:21PM +0200, Daniel Vetter wrote: > On Wed, Mar 30, 2016 at 1:09 PM, Russell King - ARM Linux > wrote: > > On Wed, Mar 30, 2016 at 11:51:18AM +0200, Daniel Vetter wrote: > >> The fb helper private gamma_set/get functions are only required when > >> the driver supports

Re: [Intel-gfx] [PATCH 03/10] drm/armada: Drop fb gamma_set/get functions

2016-03-30 Thread Daniel Vetter
On Wed, Mar 30, 2016 at 1:09 PM, Russell King - ARM Linux wrote: > On Wed, Mar 30, 2016 at 11:51:18AM +0200, Daniel Vetter wrote: >> The fb helper private gamma_set/get functions are only required when >> the driver supports paletted 8bit mode with fbdev. Armada uses 32bpp >> unconditionally, so t

Re: [Intel-gfx] [PATCH 03/10] drm/armada: Drop fb gamma_set/get functions

2016-03-30 Thread Russell King - ARM Linux
On Wed, Mar 30, 2016 at 11:51:18AM +0200, Daniel Vetter wrote: > The fb helper private gamma_set/get functions are only required when > the driver supports paletted 8bit mode with fbdev. Armada uses 32bpp > unconditionally, so this is just dead code. It also doesn't do > anything really. Let's just

[Intel-gfx] [PATCH 03/10] drm/armada: Drop fb gamma_set/get functions

2016-03-30 Thread Daniel Vetter
The fb helper private gamma_set/get functions are only required when the driver supports paletted 8bit mode with fbdev. Armada uses 32bpp unconditionally, so this is just dead code. It also doesn't do anything really. Let's just remove it. Cc: Russell King Signed-off-by: Daniel Vetter --- drive