Re: [Intel-gfx] [PATCH 02/26] drm: Switch DRIVER_ flags to an enum

2019-01-25 Thread Daniel Vetter
On Thu, Jan 24, 2019 at 06:38:33PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > > + > > + /** > > +* @DRIVER_HAVE_DMA: > > +* > > +* Driver supports DMA, the userspace DMA API will be supported. Only > > +* for legacy drivers. Do not use. > > +*/ > > + DRIVER_HAVE_DMA

Re: [Intel-gfx] [PATCH 02/26] drm: Switch DRIVER_ flags to an enum

2019-01-24 Thread Sam Ravnborg
Hi Daniel. > + > + /** > + * @DRIVER_HAVE_DMA: > + * > + * Driver supports DMA, the userspace DMA API will be supported. Only > + * for legacy drivers. Do not use. > + */ > + DRIVER_HAVE_DMA = BIT(4), What about grouping all the "legacy, do not use

[Intel-gfx] [PATCH 02/26] drm: Switch DRIVER_ flags to an enum

2019-01-24 Thread Daniel Vetter
And move the documenation we alreay have into kerneldoc, plus a bit of polish while at it. FIXME: Updates for drm_driver.driver_features are missing, need to get Sam's patches landed first. Signed-off-by: Daniel Vetter --- Documentation/gpu/drm-internals.rst | 62 - include/drm/drm