Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-28 Thread Thomas Zimmermann
Hi Am 28.01.22 um 09:15 schrieb Thomas Zimmermann: ... While with the construct below other_map; ... other_map = INITIALIZER() I can rely on the compiler complaining about uninitialized var. And in most of the cases I can just have this single line in the begginin

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-28 Thread Thomas Zimmermann
Hi Am 27.01.22 um 16:59 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 03:33:12PM +0100, Thomas Zimmermann wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to initialize a second map that takes care of reading/writing to

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 03:33:12PM +0100, Thomas Zimmermann wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to initialize a second map that takes care of reading/writing to an offset of the original map. Add a helper that c

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Thomas Zimmermann
Hi Am 27.01.22 um 11:21 schrieb Christian König: Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Thomas Zimmermann
Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to initialize a second map that takes care of reading/writing to an offset of the original map. Add a helper that copies the struct and add the offset to the proper address. Cc: Sumi

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: > Am 27.01.22 um 11:00 schrieb Daniel Vetter: > > On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: > > > On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: > > > > On Thu, Jan 27, 2022 at 09:02:54AM +0100,

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Ja

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: > On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: > > On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: > > > Am 27.01.22 um 08:57 schrieb Lucas De Marchi: > > > > On Thu, Jan 27, 2022 at 08:27:11AM +0100

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: > On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: > > Am 26.01.22 um 21:36 schrieb Lucas De Marchi: > > >

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 10:12 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:55:05AM +0100, Christian König wrote: Am 27.01.22 um 09:18 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 0

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 09:55:05AM +0100, Christian König wrote: Am 27.01.22 um 09:18 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: > Am 27.01.22 um 08:57 schrieb Lucas De Marchi: > > On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: > > > Am 26.01.22 um 21:36 schrieb Lucas De Marchi: > > > > When dma_buf_map struct is passed around, it's useful to

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 09:18 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: [SNIP] humn... not sure i

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to init

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-26 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to initialize a second map that takes care of reading/writing to an offset of the original map. Add a helper that copie

[Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-26 Thread Lucas De Marchi
When dma_buf_map struct is passed around, it's useful to be able to initialize a second map that takes care of reading/writing to an offset of the original map. Add a helper that copies the struct and add the offset to the proper address. Cc: Sumit Semwal Cc: Christian König Cc: linux-me...@vge