Re: [Intel-gfx] [PATCH 02/15] drm/i915: Don't emit mbox updates without semaphores

2013-12-17 Thread Chris Wilson
On Tue, Dec 17, 2013 at 02:02:23PM -0800, Ben Widawsky wrote: > On Tue, Dec 17, 2013 at 07:24:41PM +, Chris Wilson wrote: > > On Mon, Dec 16, 2013 at 08:50:38PM -0800, Ben Widawsky wrote: > > > Aside from the fact that it leaves confusing dumps on error capture, it > > > is entirely unnecessary

Re: [Intel-gfx] [PATCH 02/15] drm/i915: Don't emit mbox updates without semaphores

2013-12-17 Thread Ben Widawsky
On Tue, Dec 17, 2013 at 07:24:41PM +, Chris Wilson wrote: > On Mon, Dec 16, 2013 at 08:50:38PM -0800, Ben Widawsky wrote: > > Aside from the fact that it leaves confusing dumps on error capture, it > > is entirely unnecessary, and potentially harmful in cases like BDW, > > where the instruction

Re: [Intel-gfx] [PATCH 02/15] drm/i915: Don't emit mbox updates without semaphores

2013-12-17 Thread Chris Wilson
On Mon, Dec 16, 2013 at 08:50:38PM -0800, Ben Widawsky wrote: > Aside from the fact that it leaves confusing dumps on error capture, it > is entirely unnecessary, and potentially harmful in cases like BDW, > where the instruction has changed. > > In reality (seemingly), this will have no behaviora

[Intel-gfx] [PATCH 02/15] drm/i915: Don't emit mbox updates without semaphores

2013-12-16 Thread Ben Widawsky
Aside from the fact that it leaves confusing dumps on error capture, it is entirely unnecessary, and potentially harmful in cases like BDW, where the instruction has changed. In reality (seemingly), this will have no behavioral impact. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_