Re: [Intel-gfx] [PATCH 02/13] drm/i915/selftests: Add coverage of mocs registers

2019-10-21 Thread Chris Wilson
Quoting Kumar Valsan, Prathap (2019-10-21 14:52:12) > On Sat, Oct 19, 2019 at 12:20:18AM +0100, Chris Wilson wrote: > > Quoting Kumar Valsan, Prathap (2019-10-19 00:24:13) > > > On Fri, Oct 18, 2019 at 11:14:39PM +0100, Chris Wilson wrote: > > > > +static int check_l3cc_table(struct intel_engine_cs

Re: [Intel-gfx] [PATCH 02/13] drm/i915/selftests: Add coverage of mocs registers

2019-10-21 Thread Kumar Valsan, Prathap
On Sat, Oct 19, 2019 at 12:20:18AM +0100, Chris Wilson wrote: > Quoting Kumar Valsan, Prathap (2019-10-19 00:24:13) > > On Fri, Oct 18, 2019 at 11:14:39PM +0100, Chris Wilson wrote: > > > +static int check_l3cc_table(struct intel_engine_cs *engine, > > > + const struct drm_i

Re: [Intel-gfx] [PATCH 02/13] drm/i915/selftests: Add coverage of mocs registers

2019-10-18 Thread Chris Wilson
Quoting Kumar Valsan, Prathap (2019-10-19 00:24:13) > On Fri, Oct 18, 2019 at 11:14:39PM +0100, Chris Wilson wrote: > > +static int check_l3cc_table(struct intel_engine_cs *engine, > > + const struct drm_i915_mocs_table *table, > > + const u32 *vaddr,

Re: [Intel-gfx] [PATCH 02/13] drm/i915/selftests: Add coverage of mocs registers

2019-10-18 Thread Kumar Valsan, Prathap
On Fri, Oct 18, 2019 at 11:14:39PM +0100, Chris Wilson wrote: > Probe the mocs registers for new contexts and across GPU resets. Similar > to intel_workarounds, we have tables of what register values we expect > to see, so verify that user contexts are affected by them. In the > future, we should a

[Intel-gfx] [PATCH 02/13] drm/i915/selftests: Add coverage of mocs registers

2019-10-18 Thread Chris Wilson
Probe the mocs registers for new contexts and across GPU resets. Similar to intel_workarounds, we have tables of what register values we expect to see, so verify that user contexts are affected by them. In the future, we should add tests similar to intel_sseu to cover dynamic reconfigurations. Sig