Re: [Intel-gfx] [PATCH 02/10] drm/i915: Use insert_page for pwrite_fast

2015-12-22 Thread Chris Wilson
On Tue, Dec 22, 2015 at 12:03:32PM +, Tvrtko Ursulin wrote: > > On 22/12/15 11:52, Chris Wilson wrote: > >On Tue, Dec 22, 2015 at 04:45:51PM +0530, Ankitprasad Sharma wrote: > >>>Compiler does not complain about possible truncation here? I would > >>>change it to a type of equivalent width jus

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Use insert_page for pwrite_fast

2015-12-22 Thread Tvrtko Ursulin
On 22/12/15 11:52, Chris Wilson wrote: On Tue, Dec 22, 2015 at 04:45:51PM +0530, Ankitprasad Sharma wrote: Compiler does not complain about possible truncation here? I would change it to a type of equivalent width just in case. Even before it was loff_t. Never saw a compiler warning related to

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Use insert_page for pwrite_fast

2015-12-22 Thread Chris Wilson
On Tue, Dec 22, 2015 at 04:45:51PM +0530, Ankitprasad Sharma wrote: > > Compiler does not complain about possible truncation here? I would > > change it to a type of equivalent width just in case. Even before it was > > loff_t. > Never saw a compiler warning related to this truncation. Though thi

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Use insert_page for pwrite_fast

2015-12-22 Thread Ankitprasad Sharma
On Tue, 2015-12-22 at 10:44 +, Tvrtko Ursulin wrote: > Hi, > > On 22/12/15 06:20, ankitprasad.r.sha...@intel.com wrote: > > From: Ankitprasad Sharma > > > > In pwrite_fast, map an object page by page if obj_ggtt_pin fails. First, > > we try a nonblocking pin for the whole object (since that i

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Use insert_page for pwrite_fast

2015-12-22 Thread Tvrtko Ursulin
Hi, On 22/12/15 06:20, ankitprasad.r.sha...@intel.com wrote: From: Ankitprasad Sharma In pwrite_fast, map an object page by page if obj_ggtt_pin fails. First, we try a nonblocking pin for the whole object (since that is fastest if reused), then failing that we try to grab one page in the mapp

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Use insert_page for pwrite_fast

2015-12-21 Thread kbuild test robot
Hi Ankitprasad, [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v4.4-rc6 next-20151221] url: https://github.com/0day-ci/linux/commits/ankitprasad-r-sharma-intel-com/Support-for-creating-using-Stolen-memory-backed-objects/20151222-144648 base: git://anongit.free

[Intel-gfx] [PATCH 02/10] drm/i915: Use insert_page for pwrite_fast

2015-12-21 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma In pwrite_fast, map an object page by page if obj_ggtt_pin fails. First, we try a nonblocking pin for the whole object (since that is fastest if reused), then failing that we try to grab one page in the mappable aperture. It also allows us to handle objects larger than th