Re: [Intel-gfx] [PATCH 01/23] drm/i915: Drop vm.ref for duplicate vma on construction

2020-07-02 Thread Andi Shyti
Hi Chris, > Ta, going to send that as a patch? mine was a suggestion, it was easier to build the diff than explain myself :) If you want I can send it, though. Andi ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.o

Re: [Intel-gfx] [PATCH 01/23] drm/i915: Drop vm.ref for duplicate vma on construction

2020-07-02 Thread Andi Shyti
Hi Chris, > diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c > index 1f63c4a1f055..7fe1f317cd2b 100644 > --- a/drivers/gpu/drm/i915/i915_vma.c > +++ b/drivers/gpu/drm/i915/i915_vma.c > @@ -198,6 +198,7 @@ vma_create(struct drm_i915_gem_object *obj, > cmp

Re: [Intel-gfx] [PATCH 01/23] drm/i915: Drop vm.ref for duplicate vma on construction

2020-07-02 Thread Chris Wilson
Quoting Andi Shyti (2020-07-02 21:25:45) > Hi Chris, > > > diff --git a/drivers/gpu/drm/i915/i915_vma.c > > b/drivers/gpu/drm/i915/i915_vma.c > > index 1f63c4a1f055..7fe1f317cd2b 100644 > > --- a/drivers/gpu/drm/i915/i915_vma.c > > +++ b/drivers/gpu/drm/i915/i915_vma.c > > @@ -198,6 +198,7 @@ vma

Re: [Intel-gfx] [PATCH 01/23] drm/i915: Drop vm.ref for duplicate vma on construction

2020-07-02 Thread Tvrtko Ursulin
On 02/07/2020 09:32, Chris Wilson wrote: As we allow for parallel threads to create vma instances in parallel, and we only filter out the duplicates upon reacquiring the spinlock for the rbtree, we have to free the loser of the constructors' race. When freeing, we should also drop any resource

[Intel-gfx] [PATCH 01/23] drm/i915: Drop vm.ref for duplicate vma on construction

2020-07-02 Thread Chris Wilson
As we allow for parallel threads to create vma instances in parallel, and we only filter out the duplicates upon reacquiring the spinlock for the rbtree, we have to free the loser of the constructors' race. When freeing, we should also drop any resource references acquired for the redundant vma. F