Re: [Intel-gfx] [PATCH 01/18] drm/i915: Comments for semaphore clarification

2013-05-07 Thread Ben Widawsky
On Tue, May 07, 2013 at 09:51:16AM -0700, Ben Widawsky wrote: > On Tue, May 07, 2013 at 02:54:06PM +0100, Damien Lespiau wrote: > > On Sat, Apr 27, 2013 at 05:59:12PM -0700, Ben Widawsky wrote: > > > Semaphores are tied very closely to the rings in the GPU. Trivial patch > > > adds comments to the

Re: [Intel-gfx] [PATCH 01/18] drm/i915: Comments for semaphore clarification

2013-05-07 Thread Ben Widawsky
On Tue, May 07, 2013 at 02:54:06PM +0100, Damien Lespiau wrote: > On Sat, Apr 27, 2013 at 05:59:12PM -0700, Ben Widawsky wrote: > > Semaphores are tied very closely to the rings in the GPU. Trivial patch > > adds comments to the existing code so that when we add new rings we can > > include comment

Re: [Intel-gfx] [PATCH 01/18] drm/i915: Comments for semaphore clarification

2013-05-07 Thread Damien Lespiau
On Sat, Apr 27, 2013 at 05:59:12PM -0700, Ben Widawsky wrote: > Semaphores are tied very closely to the rings in the GPU. Trivial patch > adds comments to the existing code so that when we add new rings we can > include comments there as well. It also helps distinguish the ring to > semaphore mailb

[Intel-gfx] [PATCH 01/18] drm/i915: Comments for semaphore clarification

2013-04-27 Thread Ben Widawsky
Semaphores are tied very closely to the rings in the GPU. Trivial patch adds comments to the existing code so that when we add new rings we can include comments there as well. It also helps distinguish the ring to semaphore mailbox interactions by using the ringname in the semaphore data structures

Re: [Intel-gfx] [PATCH 01/18] drm/i915: Comments for semaphore clarification

2012-11-07 Thread Jani Nikula
On Tue, 06 Nov 2012, Ben Widawsky wrote: > Semaphores are tied very closely to the rings in the GPU. Trivial patch > adds comments to the existing code so that when we add new rings we can > include comments there as well. It also helps distinguish the ring to > semaphore mailbox interactions by u

[Intel-gfx] [PATCH 01/18] drm/i915: Comments for semaphore clarification

2012-11-06 Thread Ben Widawsky
Semaphores are tied very closely to the rings in the GPU. Trivial patch adds comments to the existing code so that when we add new rings we can include comments there as well. It also helps distinguish the ring to semaphore mailbox interactions by using the ringname in the semaphore data structures