Re: [Intel-gfx] [PATCH 01/12] Stop trying to out-guess mesa for BO allocation

2014-08-04 Thread Keith Packard
Eric Anholt writes: > OK, but isn't the problem with the code you're #if 0ing (which, really? > #if 0 in a patch being submitted for review?) that it's aligning to > 2*height instead of height? I went and did a bit of archaeology to figure out why it's using 2*height instead of just height. The

Re: [Intel-gfx] [PATCH 01/12] Stop trying to out-guess mesa for BO allocation

2014-08-04 Thread Eric Anholt
Keith Packard writes: > Eric Anholt writes: > >> Keith Packard writes: >> >> I don't see anything indicating that this code path is only used by >> glamor. > > True. It's a fix for DRI3 for either UXA or "none". Mesa allocates a > single page for a 1x1 texture, but this code thinks that should

Re: [Intel-gfx] [PATCH 01/12] Stop trying to out-guess mesa for BO allocation

2014-08-03 Thread Eric Anholt
Keith Packard writes: I don't see anything indicating that this code path is only used by glamor. > --- > src/uxa/intel_uxa.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/uxa/intel_uxa.c b/src/uxa/intel_uxa.c > index b396188..717754f 100644 > --- a/src/uxa/intel_uxa.c > +++ b/

Re: [Intel-gfx] [PATCH 01/12] Stop trying to out-guess mesa for BO allocation

2014-07-30 Thread Keith Packard
Eric Anholt writes: > Keith Packard writes: > > I don't see anything indicating that this code path is only used by > glamor. True. It's a fix for DRI3 for either UXA or "none". Mesa allocates a single page for a 1x1 texture, but this code thinks that should take two pages causing a texture-to-

[Intel-gfx] [PATCH 01/12] Stop trying to out-guess mesa for BO allocation

2014-07-24 Thread Keith Packard
--- src/uxa/intel_uxa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/uxa/intel_uxa.c b/src/uxa/intel_uxa.c index b396188..717754f 100644 --- a/src/uxa/intel_uxa.c +++ b/src/uxa/intel_uxa.c @@ -758,6 +758,7 @@ free_priv: goto free_priv; } +#if