Re: [Intel-gfx] [PATCH 01/10] drm/i915: rewrite the LCPLL code

2012-10-10 Thread Lespiau, Damien
On Wed, Oct 10, 2012 at 1:47 PM, Lespiau, Damien wrote: > On Fri, Oct 5, 2012 at 4:05 PM, Paulo Zanoni wrote: > >> +static int intel_ddi_get_cdclk_freq(struct drm_i915_private *dev_priv) >> +{ >> + if (I915_READ(HSW_FUSE_STRAP) & HSW_CDCLK_LIMIT) >> + return 450; > > I don't t

Re: [Intel-gfx] [PATCH 01/10] drm/i915: rewrite the LCPLL code

2012-10-10 Thread Lespiau, Damien
On Fri, Oct 5, 2012 at 4:05 PM, Paulo Zanoni wrote: > +static int intel_ddi_get_cdclk_freq(struct drm_i915_private *dev_priv) > +{ > + if (I915_READ(HSW_FUSE_STRAP) & HSW_CDCLK_LIMIT) > + return 450; I don't think reading this fused register is necessary here, it only really

[Intel-gfx] [PATCH 01/10] drm/i915: rewrite the LCPLL code

2012-10-05 Thread Paulo Zanoni
From: Paulo Zanoni Right now, we're trying to enable LCPLL at every mode set, but we're never disabling it. Also, we really don't want to be disabling LCPLL since it requires a very complex disable/enable sequence. This register should really be set by the BIOS and we shouldn't be touching it. St