Re: [Intel-gfx] [PATCH 01/10] drm/i915: remove do_retire from i915_wait_request

2012-04-21 Thread Daniel Vetter
On Sat, Apr 21, 2012 at 10:27:38AM -0700, Ben Widawsky wrote: > Just curious, it blows up on gen3 only? If not, how can I make it blow > up? I think you need the gpu fencing code to make it blow up, so gen2/3. Chris' refactoring might have changed some things in there and it doesn't blow up any lo

Re: [Intel-gfx] [PATCH 01/10] drm/i915: remove do_retire from i915_wait_request

2012-04-21 Thread Ben Widawsky
On Sat, 21 Apr 2012 19:17:11 +0200 Daniel Vetter wrote: > On Fri, Apr 20, 2012 at 06:23:23PM -0700, Ben Widawsky wrote: > > This originates from a hack by me to quickly fix a bug in an earlier > > patch where we needed control over whether or not waiting on a seqno > > actually did any retire lis

Re: [Intel-gfx] [PATCH 01/10] drm/i915: remove do_retire from i915_wait_request

2012-04-21 Thread Daniel Vetter
On Fri, Apr 20, 2012 at 06:23:23PM -0700, Ben Widawsky wrote: > This originates from a hack by me to quickly fix a bug in an earlier > patch where we needed control over whether or not waiting on a seqno > actually did any retire list processing. Since the two operations aren't > clearly related, w

[Intel-gfx] [PATCH 01/10] drm/i915: remove do_retire from i915_wait_request

2012-04-20 Thread Ben Widawsky
This originates from a hack by me to quickly fix a bug in an earlier patch where we needed control over whether or not waiting on a seqno actually did any retire list processing. Since the two operations aren't clearly related, we should pull the parameter out of the wait function, and make the cal