Re: [Intel-gfx] [PATCH] xf86-video-intel: change order of DPMS operations

2011-12-08 Thread Chris Wilson
On Thu, 08 Dec 2011 08:35:12 -0800, Keith Packard wrote: > On Thu, 08 Dec 2011 14:10:06 +, Chris Wilson > wrote: > > > I had to remind myself why both the driver and the kernel are both > > touching the backlight across DPMS; the answer as I see it is that the > > kernel only knows about th

Re: [Intel-gfx] [PATCH] xf86-video-intel: change order of DPMS operations

2011-12-08 Thread Keith Packard
On Thu, 08 Dec 2011 14:10:06 +, Chris Wilson wrote: > I had to remind myself why both the driver and the kernel are both > touching the backlight across DPMS; the answer as I see it is that the > kernel only knows about the raw backlight interface whereas the driver > adjusts it via the pref

Re: [Intel-gfx] [PATCH] xf86-video-intel: change order of DPMS operations

2011-12-08 Thread Chris Wilson
On Wed, 7 Dec 2011 16:20:41 -0800, Simon Que wrote: > The operations when setting dpms on should be in the order opposite > of what's done when setting dpms off. > > This is because of potentially conflicting effects: > ~ drmModeConnectoSetProperty() enables/disables the backlight driver. > Some

[Intel-gfx] [PATCH] xf86-video-intel: change order of DPMS operations

2011-12-07 Thread Simon Que
The operations when setting dpms on should be in the order opposite of what's done when setting dpms off. This is because of potentially conflicting effects: ~ drmModeConnectoSetProperty() enables/disables the backlight driver. Some backlight drivers such as intel_backlight set the backlight to 0