Re: [Intel-gfx] [PATCH] kernel/locking/semaphore: use wake_q in up()

2019-05-15 Thread Petr Mladek
On Fri 2019-05-10 17:20:15, Daniel Vetter wrote: > On Fri, May 10, 2019 at 11:28 AM Petr Mladek wrote: > > > > On Thu 2019-05-09 22:06:33, Daniel Vetter wrote: > > > console_trylock, called from within printk, can be called from pretty > > > much anywhere. Including try_to_wake_up. Note that this

Re: [Intel-gfx] [PATCH] kernel/locking/semaphore: use wake_q in up()

2019-05-10 Thread Daniel Vetter
On Fri, May 10, 2019 at 11:28 AM Petr Mladek wrote: > > On Thu 2019-05-09 22:06:33, Daniel Vetter wrote: > > console_trylock, called from within printk, can be called from pretty > > much anywhere. Including try_to_wake_up. Note that this isn't common, > > usually the box is in pretty bad shape at

Re: [Intel-gfx] [PATCH] kernel/locking/semaphore: use wake_q in up()

2019-05-10 Thread Petr Mladek
On Thu 2019-05-09 22:06:33, Daniel Vetter wrote: > console_trylock, called from within printk, can be called from pretty > much anywhere. Including try_to_wake_up. Note that this isn't common, > usually the box is in pretty bad shape at that point already. But it > really doesn't help when then loc

Re: [Intel-gfx] [PATCH] kernel/locking/semaphore: use wake_q in up()

2019-05-10 Thread Daniel Vetter
On Fri, May 10, 2019 at 7:50 AM Sergey Senozhatsky wrote: > > On (05/09/19 22:06), Daniel Vetter wrote: > [..] > > +/* Functions for the contended case */ > > + > > +struct semaphore_waiter { > > + struct list_head list; > > + struct task_struct *task; > > + bool up; > > +}; > > + > >

[Intel-gfx] [PATCH] kernel/locking/semaphore: use wake_q in up()

2019-05-09 Thread Daniel Vetter
console_trylock, called from within printk, can be called from pretty much anywhere. Including try_to_wake_up. Note that this isn't common, usually the box is in pretty bad shape at that point already. But it really doesn't help when then lockdep jumps in and spams the logs, potentially obscuring t