Re: [Intel-gfx] [PATCH] igt: tests/Android.mk: fix LOCAL_PATH usage

2014-01-14 Thread Damien Lespiau
On Tue, Jan 14, 2014 at 06:29:48PM +, Beckett, Robert wrote: > In Makefile language, rule and dependency definitions use immediate > expansions of variables, so they get expanded as soon as the rule is > created (1st pass). Rule implementation (a.k.a recipe) use deferred > expansion (2nd pass).

Re: [Intel-gfx] [PATCH] igt: tests/Android.mk: fix LOCAL_PATH usage

2014-01-14 Thread Beckett, Robert
x@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] igt: tests/Android.mk: fix LOCAL_PATH usage On Tue, Jan 14, 2014 at 06:01:38PM +, robert.beck...@intel.com wrote: > From: Robert Beckett > > Fix usage of shared variable LOCAL_PATH in deferred variable expansion area. Out of curios

Re: [Intel-gfx] [PATCH] igt: tests/Android.mk: fix LOCAL_PATH usage

2014-01-14 Thread Damien Lespiau
On Tue, Jan 14, 2014 at 06:01:38PM +, robert.beck...@intel.com wrote: > From: Robert Beckett > > Fix usage of shared variable LOCAL_PATH in deferred variable expansion area. Out of curiosity, do you mind explaining what the late evaluation of LOCAL_PATH broke? and why you didn't need to upda

[Intel-gfx] [PATCH] igt: tests/Android.mk: fix LOCAL_PATH usage

2014-01-14 Thread robert . beckett
From: Robert Beckett Fix usage of shared variable LOCAL_PATH in deferred variable expansion area. Signed-off-by: Robert Beckett --- tests/Android.mk |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/Android.mk b/tests/Android.mk index c65f94c..abccb7f 100644 -