Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v4)

2010-07-01 Thread Eric Anholt
On Wed, 30 Jun 2010 11:46:17 +1000, Dave Airlie wrote: > From: Dave Airlie > > The eDP spec claims a 20% overhead for the 8:10 encoding scheme used on the > wire. Take this into account when picking the lane/clock speed for the panel. > > v3: some panels are out of spec, try our best to deal w

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v3)

2010-07-01 Thread Paul Menzel
Dear Dave, just a small typo. > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 6094e42..151ed49 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -139,6 +139,12 @@ intel_dp_link_required(struct drm_device *dev, […

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v4)

2010-06-30 Thread Ben Guthro
Sorry. no change in behavior, with my E6410. On Tue, Jun 29, 2010 at 9:46 PM, Dave Airlie wrote: > From: Dave Airlie > > The eDP spec claims a 20% overhead for the 8:10 encoding scheme used on the > wire. Take this into account when picking the lane/clock speed for the panel. > > v3: some panel

[Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v4)

2010-06-29 Thread Dave Airlie
From: Dave Airlie The eDP spec claims a 20% overhead for the 8:10 encoding scheme used on the wire. Take this into account when picking the lane/clock speed for the panel. v3: some panels are out of spec, try our best to deal with them, don't refuse modes on eDP panels, and try the largest all

[Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v3)

2010-06-29 Thread Dave Airlie
From: Dave Airlie The eDP spec claims a 20% overhead for the 8:10 encoding scheme used on the wire. Take this into account when picking the lane/clock speed for the panel. v3: some panels are out of spec, try our best to deal with them, don't refuse modes on eDP panels, and try the largest all

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v2)

2010-06-29 Thread Zhenyu Wang
On 2010.06.29 09:47:04 -0400, Adam Jackson wrote: > On Tue, 2010-06-29 at 16:44 +0800, Zhenyu Wang wrote: > > On 2010.06.28 14:04:56 +0800, Zhenyu Wang wrote: > > > > > > sorry, this is still broken on the 16x9 panel. > > > > > > 'intel_dp_link_required' is 107840*18/8 = 242640, > > > 'intel_dp

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v2)

2010-06-29 Thread Adam Jackson
On Tue, 2010-06-29 at 16:44 +0800, Zhenyu Wang wrote: > On 2010.06.28 14:04:56 +0800, Zhenyu Wang wrote: > > > > sorry, this is still broken on the 16x9 panel. > > > > 'intel_dp_link_required' is 107840*18/8 = 242640, 'intel_dp_max_data_rate' > > is > > 27*1*8/10 = 216000. So it will fail i

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v2)

2010-06-28 Thread Ben Guthro
This also didn't fix the Dell E6410. I'll also note this in the bug. I'm trying to work with some contacts at Dell to get this routed to the right person as well...but am having limited luck with that, so far. On Mon, Jun 28, 2010 at 2:28 AM, Dave Airlie wrote: > On Mon, Jun 28, 2010 at 4:04 PM,

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v2)

2010-06-27 Thread Dave Airlie
On Mon, Jun 28, 2010 at 4:04 PM, Zhenyu Wang wrote: > On 2010.06.28 09:45:14 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> So the previous fix didn't work for everyone, I read the eDP spec and claims >> a 20% overhead for encoding, so make sure we take this into account when >> working o

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v2)

2010-06-27 Thread Zhenyu Wang
On 2010.06.28 09:45:14 +1000, Dave Airlie wrote: > From: Dave Airlie > > So the previous fix didn't work for everyone, I read the eDP spec and claims > a 20% overhead for encoding, so make sure we take this into account when > working out the bandwidth requirements. > > This makes my eDP panel

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup.

2010-06-27 Thread Dave Airlie
On Sat, Jun 26, 2010 at 7:56 PM, Zhenyu Wang wrote: > On 2010.06.25 16:21:40 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> We've just gotten an eDP laptop, and kms was booting to a black screen. >> >> as much as I hate Keith's magic * 3, it seems to work a lot better than the >> non-magic

[Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v2)

2010-06-27 Thread Dave Airlie
From: Dave Airlie So the previous fix didn't work for everyone, I read the eDP spec and claims a 20% overhead for encoding, so make sure we take this into account when working out the bandwidth requirements. This makes my eDP panel happy also, please test on others. Signed-off-by: Dave Airlie

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup.

2010-06-26 Thread Zhenyu Wang
On 2010.06.25 16:21:40 +1000, Dave Airlie wrote: > From: Dave Airlie > > We've just gotten an eDP laptop, and kms was booting to a black screen. > > as much as I hate Keith's magic * 3, it seems to work a lot better than the > non-magic. > > aligning the non-magic seems to make things a lot ha

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup.

2010-06-25 Thread Ben Guthro
FWIW, this didn't seem solve the boot issue I'm seeing with the Dell E6410... On Fri, Jun 25, 2010 at 2:59 AM, Keith Packard wrote: > On Fri, 25 Jun 2010 16:21:40 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> We've just gotten an eDP laptop, and kms was booting to a black screen. >> >>

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup.

2010-06-25 Thread Keith Packard
On Fri, 25 Jun 2010 16:21:40 +1000, Dave Airlie wrote: > From: Dave Airlie > > We've just gotten an eDP laptop, and kms was booting to a black screen. > > as much as I hate Keith's magic * 3, it seems to work a lot better > than the non-magic. My *3 was based on the belief that we transmit 3 b

[Intel-gfx] [PATCH] i915: fix ironlake edp panel setup.

2010-06-24 Thread Dave Airlie
From: Dave Airlie We've just gotten an eDP laptop, and kms was booting to a black screen. as much as I hate Keith's magic * 3, it seems to work a lot better than the non-magic. aligning the non-magic seems to make things a lot happier, and aligns better with what the bios appears to do, since