Re: [Intel-gfx] [PATCH] i915: Fix opregion notifications

2011-07-12 Thread Matthew Garrett
On Tue, Jul 12, 2011 at 03:20:23PM -0700, Keith Packard wrote: > Seriously? It's some kind of magic non-switch switch event? And you can > tell by checking magic bits within the event? The Intel drivers on Windows appear to have used 0x80 as a generic "Something's chanegd" notification, overload

Re: [Intel-gfx] [PATCH] i915: Fix opregion notifications

2011-07-12 Thread Keith Packard
On Tue, 12 Jul 2011 17:51:36 -0400, Matthew Garrett wrote: > - keycode = KEY_SWITCHVIDEOMODE; > + if (!acpi_notifier_call_chain(device, event, 0)) > + keycode = KEY_SWITCHVIDEOMODE; Right, acpi_notify_call_chain returns -EINVAL when the underlying func

[Intel-gfx] [PATCH] i915: Fix opregion notifications

2011-07-12 Thread Matthew Garrett
opregion-based platforms will send ACPI video event 0x80 for a range of notification types for legacy compatibility. This is interpreted as a display switch event, which may not be appropriate in the circumstances. When we receive such an event we should make sure that the platform is genuinely req