Re: [Intel-gfx] [PATCH] i915/gem_flink_race: Fix error in buffer usage

2020-11-19 Thread Chris Wilson
Quoting Hampson, Steven T (2020-11-19 18:18:14) > Chris, > > Is this acceptable? Can it be merged? It is of little use to print out that many numbers, so lets not and just show some statistics instead as this is just meant to be a guide to the reader as to whether the threads each received a rea

Re: [Intel-gfx] [PATCH] i915/gem_flink_race: Fix error in buffer usage

2020-11-19 Thread Hampson, Steven T
Chris, Is this acceptable? Can it be merged? -Original Message- From: Hampson, Steven T Sent: Wednesday, November 18, 2020 12:41 PM To: 'Chris Wilson' Cc: intel-gfx@ Subject: RE: [Intel-gfx] [PATCH] i915/gem_flink_race: Fix error in buffer usage The problem is that the

Re: [Intel-gfx] [PATCH] i915/gem_flink_race: Fix error in buffer usage

2020-11-18 Thread Chris Wilson
Quoting Hampson, Steven T (2020-11-17 23:45:23) > > > Sent from my iPhone > > > On Nov 17, 2020, at 2:28 PM, Chris Wilson wrote: > > > > Quoting Steve Hampson (2020-11-17 22:23:08) > >> A buffer in function test_flink_name was both too small and never > >> checked for overflow. Both errors a

Re: [Intel-gfx] [PATCH] i915/gem_flink_race: Fix error in buffer usage

2020-11-17 Thread Hampson, Steven T
Sent from my iPhone > On Nov 17, 2020, at 2:28 PM, Chris Wilson wrote: > > Quoting Steve Hampson (2020-11-17 22:23:08) >> A buffer in function test_flink_name was both too small and never >> checked for overflow. Both errors are fixed. > > That many numbers is not interesting. Show the rang

Re: [Intel-gfx] [PATCH] i915/gem_flink_race: Fix error in buffer usage

2020-11-17 Thread Chris Wilson
Quoting Steve Hampson (2020-11-17 22:23:08) > A buffer in function test_flink_name was both too small and never > checked for overflow. Both errors are fixed. That many numbers is not interesting. Show the range and median instead. -Chris ___ Intel-gfx

[Intel-gfx] [PATCH] i915/gem_flink_race: Fix error in buffer usage

2020-11-17 Thread Steve Hampson
A buffer in function test_flink_name was both too small and never checked for overflow. Both errors are fixed. Signed-off-by: Steve Hampson Reviewed-by: Ashutosh Dixit --- tests/i915/gem_flink_race.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/i915/gem_