On 22/06/18 10:38, Srivatsa, Anusha wrote:
-Original Message-
From: Ceraolo Spurio, Daniele
Sent: Friday, June 22, 2018 10:26 AM
To: Srivatsa, Anusha ; intel-
g...@lists.freedesktop.org
Cc: Spotswood, John A ; Mateo Lozano, Oscar
Subject: Re: [PATCH] firmware/guc: Remove USES_GUC_SU
>-Original Message-
>From: Ceraolo Spurio, Daniele
>Sent: Friday, June 22, 2018 10:26 AM
>To: Srivatsa, Anusha ; intel-
>g...@lists.freedesktop.org
>Cc: Spotswood, John A ; Mateo Lozano, Oscar
>
>Subject: Re: [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for
>suspend/resume
>
>Commit t
On Fri, 2018-06-22 at 10:25 -0700, Daniele Ceraolo Spurio wrote:
> Commit title is slightly misleading, as the USES_GUC_SUBMISSION is
> not
> removed from a suspend/resume path. the firmware tag is also
> confusing
> since this fixes an i915 bug. Maybe something like "drm/i915/guc:
> Remove
> US
Commit title is slightly misleading, as the USES_GUC_SUBMISSION is not
removed from a suspend/resume path. the firmware tag is also confusing
since this fixes an i915 bug. Maybe something like "drm/i915/guc: Remove
USES_GUC_SUBMISSION for ads programming" would be clearer
On 22/06/18 10:05, An
In the guc_ctl_debug_flags, the ads struct is programmed only
when USES_GUC_SUBMISSION is satisfied. But, this has to be
programmed for all suspend/resume cases.
Remove the condition and program the ads struct for
both huc loading and guc submission.
This issue was noticed when CI threw errors for
