[Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

2013-10-15 Thread Thomas Wood
On 11 October 2013 12:12, Ville Syrjälä wrote: > On Thu, Oct 10, 2013 at 02:19:15PM +0100, Thomas Wood wrote: >> Parse the 3D_Structure_ALL and 3D_MASK fields of the HDMI Vendor >> Specific Data Block to expose more stereo 3D modes. >> >> Signed-off-by: Thomas Wood >> --- >> drivers/gpu/drm/drm_

Re: [Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

2013-10-11 Thread Damien Lespiau
On Thu, Oct 10, 2013 at 02:19:15PM +0100, Thomas Wood wrote: > + if ((multi_present == 1 || multi_present == 2) && You could use the awesome binary literals gcc extension here and 0b01 and 0b10 to be even closer to the spec wording. There's a precedent in drivers/watchdog/sunxi_wdt.c! -- Da

Re: [Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

2013-10-11 Thread Damien Lespiau
On Fri, Oct 11, 2013 at 02:12:14PM +0300, Ville Syrjälä wrote: > On Thu, Oct 10, 2013 at 02:19:15PM +0100, Thomas Wood wrote: > > +static int add_3d_struct_modes(struct drm_connector *connector, u16 > > structure, > > + const u8 *video_db, u8 video_len, u8 video_index) > >

Re: [Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

2013-10-11 Thread Ville Syrjälä
On Thu, Oct 10, 2013 at 02:19:15PM +0100, Thomas Wood wrote: > Parse the 3D_Structure_ALL and 3D_MASK fields of the HDMI Vendor > Specific Data Block to expose more stereo 3D modes. > > Signed-off-by: Thomas Wood > --- > drivers/gpu/drm/drm_edid.c | 93 >

[Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

2013-10-10 Thread Thomas Wood
Parse the 3D_Structure_ALL and 3D_MASK fields of the HDMI Vendor Specific Data Block to expose more stereo 3D modes. Signed-off-by: Thomas Wood --- drivers/gpu/drm/drm_edid.c | 93 ++ 1 file changed, 85 insertions(+), 8 deletions(-) diff --git a/drive