Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-04-16 Thread Daniel Vetter
On Wed, Apr 15, 2015 at 02:22:54PM +, Antoine, Peter wrote: > Hi Daniel, > > I am having a look at this now, as have some time. > > So, to sum up what I think you want. > 1. Re-base and apply the patches (so that the known holes are closed in > the Nouveau driver). > 2. Add DRIVER_KMS_LEGACY_

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-04-15 Thread Antoine, Peter
t; when DRIVER_KMS_LEGACY_CONTEXT is set. > > Can you please sign up for this plus the minimal igt? > > Thanks, Daniel > > > > Peter. > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > > Vetter >

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Antoine, Peter
ubject: Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock On Tue, Mar 31, 2015 at 01:34:25PM +, Antoine, Peter wrote: > This was found by the security guys using an ioctl fuzzer. > 12 lines of code from a new unprivileged user and the kernel goes bang. > > The other crash was

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Daniel Vetter
RIVER_KMS_LEGACY_CONTEXT is set. Can you please sign up for this plus the minimal igt? Thanks, Daniel > > Peter. > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Tuesday, March 31, 2015 2:26 PM > To: Antoine

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread He, Shuang
> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Damien Lespiau > Sent: Tuesday, March 31, 2015 9:44 PM > To: Antoine, Peter > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm: Kerne

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Antoine, Peter
No problem. Will sequence them when I re-submit. -Original Message- From: Lespiau, Damien Sent: Tuesday, March 31, 2015 2:44 PM To: Antoine, Peter Cc: Daniel Vetter; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock On Tue, Mar 31, 2015 at

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Damien Lespiau
On Tue, Mar 31, 2015 at 02:38:15PM +0100, Antoine, Peter wrote: > Patch ordering, is deliberate. They are not dependent on each other. > I'll rebase and add the new dri-de...@lists.freedesktop.org when is > resubmit the patches. Ah, well, huummm. That is something new and innovative for sure. I h

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Antoine, Peter
Peter; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock On Tue, Mar 31, 2015 at 03:25:32PM +0200, Daniel Vetter wrote: > > --- > > drivers/gpu/drm/drm_lock.c | 8 > > 1 file changed, 8 insertions(+) > > > > diff -

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Antoine, Peter
l.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Tuesday, March 31, 2015 2:26 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock On Tue, Mar 31, 2015 at 09:09:33AM +0100, Peter Antoine wrote: > This patch fixes a possibl

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Damien Lespiau
On Tue, Mar 31, 2015 at 03:25:32PM +0200, Daniel Vetter wrote: > > --- > > drivers/gpu/drm/drm_lock.c | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c > > index f645268..80253a7 100644 > > --- a/drivers/gpu/drm/drm_lock

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Damien Lespiau
On Tue, Mar 31, 2015 at 03:25:32PM +0200, Daniel Vetter wrote: > > --- > > drivers/gpu/drm/drm_lock.c | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c > > index f645268..80253a7 100644 > > --- a/drivers/gpu/drm/drm_lock

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6098 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 276/276

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Daniel Vetter
On Tue, Mar 31, 2015 at 09:09:33AM +0100, Peter Antoine wrote: > This patch fixes a possible kernel crash when drm_unlock (DRM_IOCTL_UNLOCK) > is called by a application that has not had a lock created by it. This > crash can be caused by any application from all users. > > Issue: GMINL-7446 > Cha

[Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Peter Antoine
This patch fixes a possible kernel crash when drm_unlock (DRM_IOCTL_UNLOCK) is called by a application that has not had a lock created by it. This crash can be caused by any application from all users. Issue: GMINL-7446 Change-Id: I901ff713be53c5ec1c9eaf7ee0ff4314a659af05 Signed-off-by: Peter Anto