Re: [Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

2017-06-21 Thread Daniel Vetter
On Tue, Jun 20, 2017 at 05:40:25PM -0400, Sean Paul wrote: > On Tue, Jun 20, 2017 at 10:28:37PM +0200, Daniel Vetter wrote: > > In > > > > commit 91eefc05f0ac71902906b2058360e61bd25137fe > > Author: Daniel Vetter > > Date: Wed Dec 14 00:08:10 2016 +0100 > > > > drm: Tighten locking in drm_

Re: [Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

2017-06-20 Thread Pandiyan, Dhinakaran
On Tue, 2017-06-20 at 22:28 +0200, Daniel Vetter wrote: > In > > commit 91eefc05f0ac71902906b2058360e61bd25137fe > Author: Daniel Vetter > Date: Wed Dec 14 00:08:10 2016 +0100 > > drm: Tighten locking in drm_mode_getconnector > > I reordered the logic a bit in that IOCTL, but that brok

Re: [Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

2017-06-20 Thread Sean Paul
On Tue, Jun 20, 2017 at 10:28:37PM +0200, Daniel Vetter wrote: > In > > commit 91eefc05f0ac71902906b2058360e61bd25137fe > Author: Daniel Vetter > Date: Wed Dec 14 00:08:10 2016 +0100 > > drm: Tighten locking in drm_mode_getconnector > > I reordered the logic a bit in that IOCTL, but that

Re: [Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

2017-06-20 Thread Daniel Vetter
On Tue, Jun 20, 2017 at 9:32 PM, Pandiyan, Dhinakaran wrote: > Isn't this overwriting the -EFAULT return in case copy_to_user() failed > while copying the modes ? Indeed, thanks for spotting this. New patch in-flight. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 5

[Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

2017-06-20 Thread Daniel Vetter
In commit 91eefc05f0ac71902906b2058360e61bd25137fe Author: Daniel Vetter Date: Wed Dec 14 00:08:10 2016 +0100 drm: Tighten locking in drm_mode_getconnector I reordered the logic a bit in that IOCTL, but that broke userspace since it'll get the new mode list, but not the new property value

Re: [Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

2017-06-20 Thread Pandiyan, Dhinakaran
On Tue, 2017-06-20 at 11:16 +0200, Daniel Vetter wrote: > In > > commit 91eefc05f0ac71902906b2058360e61bd25137fe > Author: Daniel Vetter > Date: Wed Dec 14 00:08:10 2016 +0100 > > drm: Tighten locking in drm_mode_getconnector > > I reordered the logic a bit in that IOCTL, but that brok

Re: [Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

2017-06-20 Thread Daniel Vetter
On Tue, Jun 20, 2017 at 11:16 AM, Daniel Vetter wrote: > In > > commit 91eefc05f0ac71902906b2058360e61bd25137fe > Author: Daniel Vetter > Date: Wed Dec 14 00:08:10 2016 +0100 > > drm: Tighten locking in drm_mode_getconnector > > I reordered the logic a bit in that IOCTL, but that broke user

Re: [Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

2017-06-20 Thread H.J. Lu
On Tue, Jun 20, 2017 at 2:32 AM, Jani Nikula wrote: > On Tue, 20 Jun 2017, Daniel Vetter wrote: >> In >> >> commit 91eefc05f0ac71902906b2058360e61bd25137fe >> Author: Daniel Vetter >> Date: Wed Dec 14 00:08:10 2016 +0100 >> >> drm: Tighten locking in drm_mode_getconnector >> >> I reordered

Re: [Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

2017-06-20 Thread Jani Nikula
On Tue, 20 Jun 2017, Daniel Vetter wrote: > In > > commit 91eefc05f0ac71902906b2058360e61bd25137fe > Author: Daniel Vetter > Date: Wed Dec 14 00:08:10 2016 +0100 > > drm: Tighten locking in drm_mode_getconnector > > I reordered the logic a bit in that IOCTL, but that broke userspace > since

[Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

2017-06-20 Thread Daniel Vetter
In commit 91eefc05f0ac71902906b2058360e61bd25137fe Author: Daniel Vetter Date: Wed Dec 14 00:08:10 2016 +0100 drm: Tighten locking in drm_mode_getconnector I reordered the logic a bit in that IOCTL, but that broke userspace since it'll get the new mode list, but not the new property value