Re: [Intel-gfx] [PATCH] drm: Don't set the plane->fb to NULL on successfull set_plane

2013-02-19 Thread Thierry Reding
On Fri, Feb 15, 2013 at 09:21:37PM +0100, Daniel Vetter wrote: > We need to clear the local variable to get the refcounting right > (since the reference drm_mode_setplane holds is transferred to the > plane->fb pointer). But should be done _after_ we update the pointer. > > Breakage introduced in

Re: [Intel-gfx] [PATCH] drm: Don't set the plane->fb to NULL on successfull set_plane

2013-02-15 Thread Ville Syrjälä
On Fri, Feb 15, 2013 at 09:21:37PM +0100, Daniel Vetter wrote: > We need to clear the local variable to get the refcounting right > (since the reference drm_mode_setplane holds is transferred to the > plane->fb pointer). But should be done _after_ we update the pointer. > > Breakage introduced in

Re: [Intel-gfx] [PATCH] drm: Don't set the plane->fb to NULL on successfull set_plane

2013-02-15 Thread Jesse Barnes
On Fri, 15 Feb 2013 21:21:37 +0100 Daniel Vetter wrote: > We need to clear the local variable to get the refcounting right > (since the reference drm_mode_setplane holds is transferred to the > plane->fb pointer). But should be done _after_ we update the pointer. > > Breakage introduced in > >

[Intel-gfx] [PATCH] drm: Don't set the plane->fb to NULL on successfull set_plane

2013-02-15 Thread Daniel Vetter
We need to clear the local variable to get the refcounting right (since the reference drm_mode_setplane holds is transferred to the plane->fb pointer). But should be done _after_ we update the pointer. Breakage introduced in commit 6c2a75325c800de286166c693e0cd33c3a1c5ec8 Author: Daniel Vetter D