Re: [Intel-gfx] [PATCH] drm: Add DRM_NOTICE_IF

2015-07-28 Thread Emil Velikov
On 28/07/15 14:14, Chris Wilson wrote: > Styled after WARN_ON/DRM_ERROR_ON, this prints a mild warning message (a > KERN_NOTICE for significant but mild events) that allows us to insert > interesting events without alarming the user or bug reporting tools. > Wouldn't it be better to opt for DRM_NO

Re: [Intel-gfx] [PATCH] drm: Add DRM_NOTICE_IF

2015-07-28 Thread Emil Velikov
On 28/07/15 14:14, Chris Wilson wrote: > Styled after WARN_ON/DRM_ERROR_ON, this prints a mild warning message (a > KERN_NOTICE for significant but mild events) that allows us to insert > interesting events without alarming the user or bug reporting tools. > Wouldn't it be better to opt for DRM_NO

Re: [Intel-gfx] [PATCH] drm: Add DRM_NOTICE_IF

2015-07-28 Thread Chris Wilson
On Tue, Jul 28, 2015 at 04:58:27PM +0100, Dave Gordon wrote: > On 28/07/15 14:14, Chris Wilson wrote: > >Styled after WARN_ON/DRM_ERROR_ON, this prints a mild warning message (a > >KERN_NOTICE for significant but mild events) that allows us to insert > >interesting events without alarming the user

Re: [Intel-gfx] [PATCH] drm: Add DRM_NOTICE_IF

2015-07-28 Thread Dave Gordon
On 28/07/15 14:14, Chris Wilson wrote: Styled after WARN_ON/DRM_ERROR_ON, this prints a mild warning message (a KERN_NOTICE for significant but mild events) that allows us to insert interesting events without alarming the user or bug reporting tools. For an example I have changed a DRM_ERROR for

[Intel-gfx] [PATCH] drm: Add DRM_NOTICE_IF

2015-07-28 Thread Chris Wilson
Styled after WARN_ON/DRM_ERROR_ON, this prints a mild warning message (a KERN_NOTICE for significant but mild events) that allows us to insert interesting events without alarming the user or bug reporting tools. For an example I have changed a DRM_ERROR for being unable to set a performance enhanc