Re: [Intel-gfx] [PATCH] drm/syncobj: Fix use-after-free

2021-01-20 Thread Daniel Vetter
On Tue, Jan 19, 2021 at 02:08:12PM +0100, Christian König wrote: > Am 19.01.21 um 14:03 schrieb Daniel Vetter: > > While reviewing Christian's annotation patch I noticed that we have a > > user-after-free for the WAIT_FOR_SUBMIT case: We drop the syncobj > > reference before we've completed the wai

Re: [Intel-gfx] [PATCH] drm/syncobj: Fix use-after-free

2021-01-19 Thread Christian König
Am 19.01.21 um 14:03 schrieb Daniel Vetter: While reviewing Christian's annotation patch I noticed that we have a user-after-free for the WAIT_FOR_SUBMIT case: We drop the syncobj reference before we've completed the waiting. Of course usually there's nothing bad happening here since userspace k

[Intel-gfx] [PATCH] drm/syncobj: Fix use-after-free

2021-01-19 Thread Daniel Vetter
While reviewing Christian's annotation patch I noticed that we have a user-after-free for the WAIT_FOR_SUBMIT case: We drop the syncobj reference before we've completed the waiting. Of course usually there's nothing bad happening here since userspace keeps the reference, but we can't rely on users