Re: [Intel-gfx] [PATCH] drm/msm: Don't init ww_mutec acquire ctx before needed

2019-11-21 Thread Daniel Vetter
On Wed, Nov 20, 2019 at 04:24:48PM -0800, Rob Clark wrote: > On Wed, Nov 20, 2019 at 2:56 AM Daniel Vetter wrote: > > > > For locking semantics it really doesn't matter when we grab the > > ticket. But for lockdep validation it does: the acquire ctx is a fake > > lockdep. Since other drivers might

Re: [Intel-gfx] [PATCH] drm/msm: Don't init ww_mutec acquire ctx before needed

2019-11-20 Thread Rob Clark
On Wed, Nov 20, 2019 at 2:56 AM Daniel Vetter wrote: > > For locking semantics it really doesn't matter when we grab the > ticket. But for lockdep validation it does: the acquire ctx is a fake > lockdep. Since other drivers might want to do a full multi-lock dance > in their fault-handler, not jus

[Intel-gfx] [PATCH] drm/msm: Don't init ww_mutec acquire ctx before needed

2019-11-20 Thread Daniel Vetter
For locking semantics it really doesn't matter when we grab the ticket. But for lockdep validation it does: the acquire ctx is a fake lockdep. Since other drivers might want to do a full multi-lock dance in their fault-handler, not just lock a single dma_resv. Therefore we must init the acquire_ctx