Re: [Intel-gfx] [PATCH] drm/locking: Allow NULL crtc in drm_modeset_legacy_acquire_ctx

2014-11-24 Thread Jasper St. Pierre
This still crashes for me: kernel: [ cut here ] kernel: WARNING: at drivers/gpu/drm/drm_modeset_lock.c:219 drm_modeset_legacy_acquire_ctx+0x38/0x40() kernel: Modules linked in: kernel: CPU: 0 PID: 586 Comm: Xorg Not tainted 3.10.33-02454-g1c4eeb3-dirty #196 kernel: [] (unwi

Re: [Intel-gfx] [PATCH] drm/locking: Allow NULL crtc in

2014-11-22 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 367/367

[Intel-gfx] [PATCH] drm/locking: Allow NULL crtc in drm_modeset_legacy_acquire_ctx

2014-11-21 Thread Daniel Vetter
I've missed checking this and so didn't notice that there's a NULL check missing. Since depending upon calling context the crtc might not even be there (disable-me-harder does happen around planes, especially in cleanup code) we need to dodge the oops and look at the global acquire ctx. v2: Actual

Re: [Intel-gfx] [PATCH] drm/locking: Allow NULL crtc in drm_modeset_legacy_acquire_ctx

2014-11-21 Thread Ville Syrjälä
On Fri, Nov 21, 2014 at 04:40:18PM +0100, Daniel Vetter wrote: > I've missed checking this and so didn't notice that there's a NULL > check missing. Since depending upon calling context the crtc might not > even be there (disable-me-harder does happen around planes, especially > in cleanup code) we

[Intel-gfx] [PATCH] drm/locking: Allow NULL crtc in drm_modeset_legacy_acquire_ctx

2014-11-21 Thread Daniel Vetter
I've missed checking this and so didn't notice that there's a NULL check missing. Since depending upon calling context the crtc might not even be there (disable-me-harder does happen around planes, especially in cleanup code) we need to dodge the oops and look at the global acquire ctx. Reported-b