Re: [Intel-gfx] [PATCH] drm/i915: vma/ppgtt lifetime rules

2014-07-30 Thread Thierry, Michel
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Tuesday, July 29, 2014 8:20 PM > To: Ben Widawsky > Cc: Thierry, Michel; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: vma

Re: [Intel-gfx] [PATCH] drm/i915: vma/ppgtt lifetime rules

2014-07-29 Thread Daniel Vetter
On Tue, Jul 29, 2014 at 11:44:51AM -0700, Ben Widawsky wrote: > On Tue, Jul 29, 2014 at 11:32:07AM -0700, Ben Widawsky wrote: > > On Tue, Jul 29, 2014 at 11:08:05AM +0100, Michel Thierry wrote: > > > VMAs should take a reference of the address space they use. > > > > > > Now, when the fd is closed

Re: [Intel-gfx] [PATCH] drm/i915: vma/ppgtt lifetime rules

2014-07-29 Thread Ben Widawsky
On Tue, Jul 29, 2014 at 11:32:07AM -0700, Ben Widawsky wrote: > On Tue, Jul 29, 2014 at 11:08:05AM +0100, Michel Thierry wrote: > > VMAs should take a reference of the address space they use. > > > > Now, when the fd is closed, it will release the ref that the context was > > holding, but it will

Re: [Intel-gfx] [PATCH] drm/i915: vma/ppgtt lifetime rules

2014-07-29 Thread Ben Widawsky
On Tue, Jul 29, 2014 at 11:08:05AM +0100, Michel Thierry wrote: > VMAs should take a reference of the address space they use. > > Now, when the fd is closed, it will release the ref that the context was > holding, but it will still be referenced by any vmas that are still > active. > > ppgtt_rele

Re: [Intel-gfx] [PATCH] drm/i915: vma/ppgtt lifetime rules

2014-07-29 Thread Chris Wilson
On Tue, Jul 29, 2014 at 01:06:40PM +0200, Daniel Vetter wrote: > On Tue, Jul 29, 2014 at 11:08:05AM +0100, Michel Thierry wrote: > > VMAs should take a reference of the address space they use. > > > > Now, when the fd is closed, it will release the ref that the context was > > holding, but it will

Re: [Intel-gfx] [PATCH] drm/i915: vma/ppgtt lifetime rules

2014-07-29 Thread Daniel Vetter
On Tue, Jul 29, 2014 at 11:08:05AM +0100, Michel Thierry wrote: > VMAs should take a reference of the address space they use. > > Now, when the fd is closed, it will release the ref that the context was > holding, but it will still be referenced by any vmas that are still > active. > > ppgtt_rele

[Intel-gfx] [PATCH] drm/i915: vma/ppgtt lifetime rules

2014-07-29 Thread Michel Thierry
VMAs should take a reference of the address space they use. Now, when the fd is closed, it will release the ref that the context was holding, but it will still be referenced by any vmas that are still active. ppgtt_release() should then only be called when the last thing referencing it releases t