Re: [Intel-gfx] [PATCH] drm/i915: use macros to assign mmio access functions

2014-10-24 Thread Daniel Vetter
On Thu, Oct 23, 2014 at 03:28:24PM +0800, Yu Zhang wrote: Empty commit messages aren't good. Even for really simple refactoring please explain in 1-2 sentences the motivation for the patch, since the change itself doesn't really say that. For this one I've added something while merging. > Signed-

Re: [Intel-gfx] [PATCH] drm/i915: use macros to assign mmio access functions

2014-10-23 Thread Yu, Zhang
On 10/23/2014 8:28 PM, Daniel Vetter wrote: On Thu, Oct 23, 2014 at 03:28:24PM +0800, Yu Zhang wrote: Empty commit messages aren't good. Even for really simple refactoring please explain in 1-2 sentences the motivation for the patch, since the change itself doesn't really say that. For this on

[Intel-gfx] [PATCH] drm/i915: use macros to assign mmio access functions

2014-10-23 Thread Yu Zhang
Signed-off-by: Yu Zhang --- drivers/gpu/drm/i915/intel_uncore.c | 76 ++--- 1 file changed, 28 insertions(+), 48 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index 0b0f4f8..9b228e3 100644 --- a/drivers/gpu/dr