Re: [Intel-gfx] [PATCH] drm/i915: simplify ppgtt setup

2012-04-11 Thread Daniel Vetter
On Tue, Apr 10, 2012 at 04:33:38PM +0100, Chris Wilson wrote: > On Tue, 10 Apr 2012 17:29:17 +0200, daniel.vet...@ffwll.ch wrote: > > From: Daniel Vetter > > > > We don't need the pt_addr for the !dmar case, so drop the else and > > move the if (dmar) condition out of the loop. > > > > v2: Fixup

Re: [Intel-gfx] [PATCH] drm/i915: simplify ppgtt setup

2012-04-10 Thread Chris Wilson
On Tue, 10 Apr 2012 17:29:17 +0200, daniel.vet...@ffwll.ch wrote: > From: Daniel Vetter > > We don't need the pt_addr for the !dmar case, so drop the else and > move the if (dmar) condition out of the loop. > > v2: Fixup whitespace damage noticed by Chris Wilson. > > v3: Collapse the two identi

[Intel-gfx] [PATCH] drm/i915: simplify ppgtt setup

2012-04-10 Thread daniel . vetter
From: Daniel Vetter We don't need the pt_addr for the !dmar case, so drop the else and move the if (dmar) condition out of the loop. v2: Fixup whitespace damage noticed by Chris Wilson. v3: Collapse the two identical if blocks. Chris Wilson makes me look like a moron right now ... Noticed-by:

Re: [Intel-gfx] [PATCH] drm/i915: simplify ppgtt setup

2012-04-10 Thread Chris Wilson
On Tue, 10 Apr 2012 17:04:35 +0200, Daniel Vetter wrote: > We don't need the pt_addr for the !dmar case, so drop the else and > move the if (dmar) condition out of the loop. > > v2: Fixup whitespace damage noticed by Chris Wilson. > > Noticed-by: Konstantin Belousov > Signed-Off-by: Daniel Vet

[Intel-gfx] [PATCH] drm/i915: simplify ppgtt setup

2012-04-10 Thread Daniel Vetter
We don't need the pt_addr for the !dmar case, so drop the else and move the if (dmar) condition out of the loop. v2: Fixup whitespace damage noticed by Chris Wilson. Noticed-by: Konstantin Belousov Signed-Off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem_gtt.c | 10 +- 1 files

Re: [Intel-gfx] [PATCH] drm/i915: simplify ppgtt setup

2012-04-10 Thread Chris Wilson
On Tue, 10 Apr 2012 16:25:54 +0200, Daniel Vetter wrote: > We don't need the pt_addr for the !dmar case, so drop the else and > move the if (dmar) condition out of the loop. > > Noticed-by: Konstantin Belousov > Signed-Off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_gem_gtt.c |7 +

[Intel-gfx] [PATCH] drm/i915: simplify ppgtt setup

2012-04-10 Thread Daniel Vetter
We don't need the pt_addr for the !dmar case, so drop the else and move the if (dmar) condition out of the loop. Noticed-by: Konstantin Belousov Signed-Off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem_gtt.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/dr