Re: [Intel-gfx] [PATCH] drm/i915: rip out unnecessary calls to drm_mode_set_crtcinfo

2012-05-04 Thread Daniel Vetter
On Thu, May 03, 2012 at 03:51:58PM +0200, Daniel Vetter wrote: > Our handling of the crtc timing computation has been nicely > cargo-culted with calls to drm_mode_set_crtcinfo sprinkled all over > the place. But with > > commit f9bef081c3c3f77bec54454872e98d3ec635756f > Author: Daniel Vetter > Da

[Intel-gfx] [PATCH] drm/i915: rip out unnecessary calls to drm_mode_set_crtcinfo

2012-05-03 Thread Daniel Vetter
Our handling of the crtc timing computation has been nicely cargo-culted with calls to drm_mode_set_crtcinfo sprinkled all over the place. But with commit f9bef081c3c3f77bec54454872e98d3ec635756f Author: Daniel Vetter Date: Sun Apr 15 19:53:19 2012 +0200 drm/i915: don't clobber the special

Re: [Intel-gfx] [PATCH] drm/i915: rip out unnecessary calls to drm_mode_set_crtcinfo

2012-05-03 Thread Chris Wilson
On Tue, 24 Apr 2012 17:37:56 +0200, Daniel Vetter wrote: > On Tue, Apr 24, 2012 at 04:11:43PM +0100, Chris Wilson wrote: > > On Tue, 24 Apr 2012 15:41:37 +0200, Daniel Vetter > > wrote: > > > the only places we actually need the crtc timings is in the mode_set > > > function. > > > > > > So we

Re: [Intel-gfx] [PATCH] drm/i915: rip out unnecessary calls to drm_mode_set_crtcinfo

2012-04-24 Thread Daniel Vetter
On Tue, Apr 24, 2012 at 04:11:43PM +0100, Chris Wilson wrote: > On Tue, 24 Apr 2012 15:41:37 +0200, Daniel Vetter > wrote: > > the only places we actually need the crtc timings is in the mode_set > > function. > > > > So we can now safely rip out all the remaining calls to set_crtcinfo > > left

Re: [Intel-gfx] [PATCH] drm/i915: rip out unnecessary calls to drm_mode_set_crtcinfo

2012-04-24 Thread Chris Wilson
On Tue, 24 Apr 2012 15:41:37 +0200, Daniel Vetter wrote: > the only places we actually need the crtc timings is in the mode_set > function. > > So we can now safely rip out all the remaining calls to set_crtcinfo > left in the driver and clean up this confusion. I have a little flicker of doubt

[Intel-gfx] [PATCH] drm/i915: rip out unnecessary calls to drm_mode_set_crtcinfo

2012-04-24 Thread Daniel Vetter
Our handling of the crtc timing computation has been nicely cargo-culted with calls to drm_mode_set_crtcinfo sprinkled all over the place. But with commit f9bef081c3c3f77bec54454872e98d3ec635756f Author: Daniel Vetter Date: Sun Apr 15 19:53:19 2012 +0200 drm/i915: don't clobber the special