Re: [Intel-gfx] [PATCH] drm/i915: rip out the PM_IIR WARN, again

2013-05-31 Thread Daniel Vetter
On Fri, May 31, 2013 at 05:22:07PM +0200, Daniel Vetter wrote: > On Fri, May 31, 2013 at 04:11:59PM +0100, Damien Lespiau wrote: > > On Fri, May 31, 2013 at 09:12:19AM +0200, Daniel Vetter wrote: > > > This has accidentally been reintroduced with > > > > > > commit 22aae764a3fa21ee502b99e8986cb4e4

Re: [Intel-gfx] [PATCH] drm/i915: rip out the PM_IIR WARN, again

2013-05-31 Thread Daniel Vetter
On Fri, May 31, 2013 at 04:11:59PM +0100, Damien Lespiau wrote: > On Fri, May 31, 2013 at 09:12:19AM +0200, Daniel Vetter wrote: > > This has accidentally been reintroduced with > > > > commit 22aae764a3fa21ee502b99e8986cb4e49ec14cfe > > Author: Ben Widawsky > > Date: Tue May 28 19:22:24 2013

Re: [Intel-gfx] [PATCH] drm/i915: rip out the PM_IIR WARN, again

2013-05-31 Thread Damien Lespiau
On Fri, May 31, 2013 at 09:12:19AM +0200, Daniel Vetter wrote: > This has accidentally been reintroduced with > > commit 22aae764a3fa21ee502b99e8986cb4e49ec14cfe > Author: Ben Widawsky > Date: Tue May 28 19:22:24 2013 -0700 > > drm/i915: Create a more generic pm handler for hsw+ > > See

[Intel-gfx] [PATCH] drm/i915: rip out the PM_IIR WARN, again

2013-05-31 Thread Daniel Vetter
This has accidentally been reintroduced with commit 22aae764a3fa21ee502b99e8986cb4e49ec14cfe Author: Ben Widawsky Date: Tue May 28 19:22:24 2013 -0700 drm/i915: Create a more generic pm handler for hsw+ See commit 58bf8062d0b293b8e1028e5b0342082002886bd4 Author: Daniel Vetter Date:

Re: [Intel-gfx] [PATCH] drm/i915: rip out the PM_IIR WARN

2012-06-22 Thread Daniel Vetter
On Thu, Jun 21, 2012 at 02:55:22PM +0200, Daniel Vetter wrote: > After banging my head against this for the past few months, I still > don't see how this could possible race under the premise that once an > irq bit is masked in PM_IMR and reset in PM_IIR it won't show up again > until we unmask it

Re: [Intel-gfx] [PATCH] drm/i915: rip out the PM_IIR WARN

2012-06-21 Thread Chris Wilson
On Thu, 21 Jun 2012 14:55:22 +0200, Daniel Vetter wrote: > After banging my head against this for the past few months, I still > don't see how this could possible race under the premise that once an > irq bit is masked in PM_IMR and reset in PM_IIR it won't show up again > until we unmask it in P

[Intel-gfx] [PATCH] drm/i915: rip out the PM_IIR WARN

2012-06-21 Thread Daniel Vetter
After banging my head against this for the past few months, I still don't see how this could possible race under the premise that once an irq bit is masked in PM_IMR and reset in PM_IIR it won't show up again until we unmask it in PM_IMR. Still, we have reports of this being seen in the wild. Now