Re: [Intel-gfx] [PATCH] drm/i915: rework the error handling in *_dpll_params

2022-03-04 Thread Ville Syrjälä
On Fri, Mar 04, 2022 at 11:11:54PM +0200, Ville Syrjälä wrote: > On Fri, Mar 04, 2022 at 01:03:55PM -0800, t...@redhat.com wrote: > > From: Tom Rix > > > > Clang static analysis reports this issue > > intel_dpll.c:472:31: warning: The left operand of '-' > > is a garbage value [core.UndefinedBi

Re: [Intel-gfx] [PATCH] drm/i915: rework the error handling in *_dpll_params

2022-03-04 Thread Ville Syrjälä
On Fri, Mar 04, 2022 at 01:03:55PM -0800, t...@redhat.com wrote: > From: Tom Rix > > Clang static analysis reports this issue > intel_dpll.c:472:31: warning: The left operand of '-' > is a garbage value [core.UndefinedBinaryOperatorResult] > this_err = abs(clock.dot - target); >

[Intel-gfx] [PATCH] drm/i915: rework the error handling in *_dpll_params

2022-03-04 Thread trix
From: Tom Rix Clang static analysis reports this issue intel_dpll.c:472:31: warning: The left operand of '-' is a garbage value [core.UndefinedBinaryOperatorResult] this_err = abs(clock.dot - target); ~ ^ In a loop clock.dot is set on successful call to i9xx_calc_dpl