Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-23 Thread Daniel Vetter
On Sun, Apr 22, 2012 at 07:57:33PM -0700, Ben Widawsky wrote: > On Sun, 22 Apr 2012 18:39:23 +0100 > Chris Wilson wrote: > > > On Sun, 22 Apr 2012 10:35:29 -0700, Ben Widawsky > > wrote: > > > On Sun, 22 Apr 2012 16:49:53 +0100 > > > Chris Wilson wrote: > > > > > > > On Fri, 20 Apr 2012 11:50:

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Ben Widawsky
On Sun, 22 Apr 2012 18:39:23 +0100 Chris Wilson wrote: > On Sun, 22 Apr 2012 10:35:29 -0700, Ben Widawsky > wrote: > > On Sun, 22 Apr 2012 16:49:53 +0100 > > Chris Wilson wrote: > > > > > On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky > > > wrote: > > > > Chris' fix for my 32b breakage was

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Ben Widawsky
Google fail.  I'd like to go back to my 32b machine and try to reproduce this.   your patch seems fine to me though.  Original message Subject: Re: [PATCH] drm/i915: rc6 residency (fix the fix) From: Chris Wilson To: Ben Widawsky CC: intel-gfx@lists.freedesktop.org,Ben Widaw

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Chris Wilson
On Sun, 22 Apr 2012 11:02:32 -0700, Ben Widawsky wrote: > Does div_round64 work for you? I think that is the best solution. Only exists in drivers/cpuidle/governors/menu.c, and still would need a do_div to avoid the subsequent 64-bit division. The choice appears to be either perform the divide b

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Ben Widawsky
On Sun, 22 Apr 2012 18:39:23 +0100 Chris Wilson wrote: > On Sun, 22 Apr 2012 10:35:29 -0700, Ben Widawsky > wrote: > > On Sun, 22 Apr 2012 16:49:53 +0100 > > Chris Wilson wrote: > > > > > On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky > > > wrote: > > > > Chris' fix for my 32b breakage was

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Chris Wilson
On Sun, 22 Apr 2012 10:35:29 -0700, Ben Widawsky wrote: > On Sun, 22 Apr 2012 16:49:53 +0100 > Chris Wilson wrote: > > > On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky > > wrote: > > > Chris' fix for my 32b breakage was incorrect. do_div returns a > > > remainder. Go back to a divide macro wh

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Ben Widawsky
On Sun, 22 Apr 2012 16:49:53 +0100 Chris Wilson wrote: > On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky > wrote: > > Chris' fix for my 32b breakage was incorrect. do_div returns a > > remainder. Go back to a divide macro which is more 32b friendly. > > > > Tested on x86-64. > > > > This has

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Chris Wilson
On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky wrote: > Chris' fix for my 32b breakage was incorrect. do_div returns a > remainder. Go back to a divide macro which is more 32b friendly. > > Tested on x86-64. > > This has only been compile tested on 32b systems. Doesn't compile on my 32-bit sys

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-20 Thread Daniel Vetter
On Fri, Apr 20, 2012 at 08:24:04PM +0100, Chris Wilson wrote: > On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky wrote: > > Chris' fix for my 32b breakage was incorrect. do_div returns a > > remainder. Go back to a divide macro which is more 32b friendly. > > > > Tested on x86-64. > > > > This h

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-20 Thread Chris Wilson
On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky wrote: > Chris' fix for my 32b breakage was incorrect. do_div returns a > remainder. Go back to a divide macro which is more 32b friendly. > > Tested on x86-64. > > This has only been compile tested on 32b systems. > > Bugzilla: https://bugs.free

[Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-20 Thread Ben Widawsky
Chris' fix for my 32b breakage was incorrect. do_div returns a remainder. Go back to a divide macro which is more 32b friendly. Tested on x86-64. This has only been compile tested on 32b systems. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48756 Cc: Chris Wilson Signed-off-by: Ben Wi