Re: [Intel-gfx] [PATCH] drm/i915: properly check for MODESET for kms driver ioctls

2012-04-24 Thread Chris Wilson
On Tue, 24 Apr 2012 09:55:08 +0200, Daniel Vetter wrote: > Also ditch the cargo-culted dev_priv checks - either we have a > giant hole in our setup code or this is useless. Plainly bogus > to check for it in either case. > > v2: Chris Wilson noticed that I've missed one bogus dev_priv check. >

Re: [Intel-gfx] [PATCH] drm/i915: properly check for MODESET for kms driver ioctls

2012-04-24 Thread Chris Wilson
On Tue, 24 Apr 2012 09:55:08 +0200, Daniel Vetter wrote: > Also ditch the cargo-culted dev_priv checks - either we have a > giant hole in our setup code or this is useless. Plainly bogus > to check for it in either case. > > v2: Chris Wilson noticed that I've missed one bogus dev_priv check. >

[Intel-gfx] [PATCH] drm/i915: properly check for MODESET for kms driver ioctls

2012-04-24 Thread Daniel Vetter
Also ditch the cargo-culted dev_priv checks - either we have a giant hole in our setup code or this is useless. Plainly bogus to check for it in either case. v2: Chris Wilson noticed that I've missed one bogus dev_priv check. v3: The check in the overlay code is redundant (Chris) Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915: properly check for MODESET for kms driver ioctls

2012-04-24 Thread Chris Wilson
On Tue, 24 Apr 2012 08:19:31 +0200, Daniel Vetter wrote: > diff --git a/drivers/gpu/drm/i915/intel_overlay.c > b/drivers/gpu/drm/i915/intel_overlay.c > index 0f0fe31..aa14235 100644 > --- a/drivers/gpu/drm/i915/intel_overlay.c > +++ b/drivers/gpu/drm/i915/intel_overlay.c > @@ -1122,10 +1122,8 @@

[Intel-gfx] [PATCH] drm/i915: properly check for MODESET for kms driver ioctls

2012-04-24 Thread Daniel Vetter
Also ditch the cargo-culted dev_priv checks - either we have a giant hole in our setup code or this is useless. Plainly bogus to check for it in either case. v2: Chris Wilson noticed that I've missed one bogus dev_priv check. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c