On Thu, Jul 17, 2014 at 10:58:17AM -0700, Rodrigo Vivi wrote:
> With the increasing number of rings,
> we probably have more information to print than we were printing.
>
> v2: Loop only over active rings and print info with ring names.
>
> Cc: Ben Widawsky
> Signed-off-by: Rodrigo Vivi
> ---
>
With the increasing number of rings,
we probably have more information to print than we were printing.
v2: Loop only over active rings and print info with ring names.
Cc: Ben Widawsky
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_gpu_error.c | 24
1 file ch
On Thu, Jul 17, 2014 at 05:36:52PM -0700, Vivi, Rodrigo wrote:
> You mean you prefer the the loop with for (i = 0; i < hweight(ring_mask);
> i++) {
> instead? I thought you were ok with either and I preferred this one just to
> be on the safest side and let userspace parse it properly.
I can li
You mean you prefer the the loop with for (i = 0; i < hweight(ring_mask); i++)
{
instead? I thought you were ok with either and I preferred this one just to be
on the safest side and let userspace parse it properly.
Or do you prefer that other version with double loop but with names of rings?
On Thu, Jul 17, 2014 at 09:39:55AM -0700, Rodrigo Vivi wrote:
> With the increasing number of rings,
> we probably have more information to print than we were printing.
After our discussion were you going to send a new patch?
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
With the increasing number of rings,
we probably have more information to print than we were printing.
Cc: Ben Widawsky
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_gpu_error.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i