Re: [Intel-gfx] [PATCH] drm/i915: permit zero valued dmap in for_each_sgt_dma

2019-02-11 Thread Chris Wilson
Quoting Matthew Auld (2019-02-11 14:39:38) > On Wed, 30 Jan 2019 at 20:03, Chris Wilson wrote: > > > > Quoting Matthew Auld (2019-01-30 19:18:25) > > > Break on NULL iter.sgp, rather than dmap == 0, on the off chance that we > > > have some hypothetical selftest or similar in the future that consi

Re: [Intel-gfx] [PATCH] drm/i915: permit zero valued dmap in for_each_sgt_dma

2019-02-11 Thread Matthew Auld
On Wed, 30 Jan 2019 at 20:03, Chris Wilson wrote: > > Quoting Matthew Auld (2019-01-30 19:18:25) > > Break on NULL iter.sgp, rather than dmap == 0, on the off chance that we > > have some hypothetical selftest or similar in the future that considers > > dmap = 0 to be perfectly valid. > > 0 == DMA

Re: [Intel-gfx] [PATCH] drm/i915: permit zero valued dmap in for_each_sgt_dma

2019-01-30 Thread Chris Wilson
Quoting Matthew Auld (2019-01-30 19:18:25) > Break on NULL iter.sgp, rather than dmap == 0, on the off chance that we > have some hypothetical selftest or similar in the future that considers > dmap = 0 to be perfectly valid. 0 == DMA_MAPPING_ERROR It wouldn't be a dma iterator at that point. fo

[Intel-gfx] [PATCH] drm/i915: permit zero valued dmap in for_each_sgt_dma

2019-01-30 Thread Matthew Auld
Break on NULL iter.sgp, rather than dmap == 0, on the off chance that we have some hypothetical selftest or similar in the future that considers dmap = 0 to be perfectly valid. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)