Re: [Intel-gfx] [PATCH] drm/i915: panel fitter hw state readout&check support

2013-05-14 Thread Daniel Vetter
On Fri, May 10, 2013 at 03:22:17PM +0200, Daniel Vetter wrote: > On Fri, May 10, 2013 at 3:07 PM, Mika Kuoppala > wrote: > > As discussed in irc, we might come across a case where panel fitter > > is not aligned to the same pipe in ilk+. Perhaps warn if we > > encounter such a weird setup? > > Yea

Re: [Intel-gfx] [PATCH] drm/i915: panel fitter hw state readout&check support

2013-05-10 Thread Daniel Vetter
On Fri, May 10, 2013 at 3:07 PM, Mika Kuoppala wrote: > As discussed in irc, we might come across a case where panel fitter > is not aligned to the same pipe in ilk+. Perhaps warn if we > encounter such a weird setup? Yeah, our current code doesn't support different pfit->pipe associations. They'

Re: [Intel-gfx] [PATCH] drm/i915: panel fitter hw state readout&check support

2013-05-10 Thread Mika Kuoppala
Daniel Vetter writes: > On Fri, May 10, 2013 at 02:37:59PM +0300, Mika Kuoppala wrote: >> >> Hi Daniel, >> >> Daniel Vetter writes: >> >> > Pfit state readout is a bit ugly on gen2/3 due to the intermingling >> > with the lvds state, but alas. >> > >> > Also note that since state is always cl

Re: [Intel-gfx] [PATCH] drm/i915: panel fitter hw state readout&check support

2013-05-10 Thread Daniel Vetter
On Fri, May 10, 2013 at 02:37:59PM +0300, Mika Kuoppala wrote: > > Hi Daniel, > > Daniel Vetter writes: > > > Pfit state readout is a bit ugly on gen2/3 due to the intermingling > > with the lvds state, but alas. > > > > Also note that since state is always cleared to zero we can > > unconditon

Re: [Intel-gfx] [PATCH] drm/i915: panel fitter hw state readout&check support

2013-05-10 Thread Mika Kuoppala
Hi Daniel, Daniel Vetter writes: > Pfit state readout is a bit ugly on gen2/3 due to the intermingling > with the lvds state, but alas. > > Also note that since state is always cleared to zero we can > unconditonally compare all the state and completely neglect the actual > platform we're runni

[Intel-gfx] [PATCH] drm/i915: panel fitter hw state readout&check support

2013-05-07 Thread Daniel Vetter
Pfit state readout is a bit ugly on gen2/3 due to the intermingling with the lvds state, but alas. Also note that since state is always cleared to zero we can unconditonally compare all the state and completely neglect the actual platform we're running on. v2: Properly check for the pfit power do