Re: [Intel-gfx] [PATCH] drm/i915: move LVDS support check to output setup

2013-02-12 Thread Chris Wilson
On Tue, Feb 12, 2013 at 07:37:08PM +0200, Jani Nikula wrote: > On Tue, 12 Feb 2013, Chris Wilson wrote: > > On Tue, Feb 12, 2013 at 07:06:59PM +0200, Jani Nikula wrote: > >> Keep all the platform output selection in intel_output_setup(), and don't > >> scatter it around. > > > > I see this as doin

Re: [Intel-gfx] [PATCH] drm/i915: move LVDS support check to output setup

2013-02-12 Thread Jani Nikula
On Tue, 12 Feb 2013, Chris Wilson wrote: > On Tue, Feb 12, 2013 at 07:06:59PM +0200, Jani Nikula wrote: >> Keep all the platform output selection in intel_output_setup(), and don't >> scatter it around. > > I see this as doing the opposite. You are littering an already over > complicated routine w

Re: [Intel-gfx] [PATCH] drm/i915: move LVDS support check to output setup

2013-02-12 Thread Chris Wilson
On Tue, Feb 12, 2013 at 07:06:59PM +0200, Jani Nikula wrote: > Keep all the platform output selection in intel_output_setup(), and don't > scatter it around. I see this as doing the opposite. You are littering an already over complicated routine with LVDS specific information. > As a useful side

[Intel-gfx] [PATCH] drm/i915: move LVDS support check to output setup

2013-02-12 Thread Jani Nikula
Keep all the platform output selection in intel_output_setup(), and don't scatter it around. As a useful side effect, do not try to enable LVDS on HSW or VLV. Some checks are done in a slightly different order than before, and on some platforms VGA is now initialized before LVDS. Signed-off-by: J