Re: [Intel-gfx] [PATCH] drm/i915: hangcheck timeout for debugfs

2011-06-26 Thread Chris Wilson
On Sat, 25 Jun 2011 17:20:11 -0700, Ben Widawsky wrote: > If you feel strongly about a module parameter being the better solution, > I will code it up. The more I think about about it, the more opposed I am to putting parameters in debugfs, or more correctly being caught putting them there. ;-)

Re: [Intel-gfx] [PATCH] drm/i915: hangcheck timeout for debugfs

2011-06-25 Thread Ben Widawsky
On Sat, Jun 25, 2011 at 10:23:28AM +0100, Chris Wilson wrote: > On Fri, 24 Jun 2011 08:46:53 -0700, Ben Widawsky wrote: > > On Fri, Jun 24, 2011 at 12:48:22AM +0100, Chris Wilson wrote: > > > On Thu, 23 Jun 2011 15:49:14 -0700, Ben Widawsky > > > wrote: > > > > Provide a user accessible way to c

Re: [Intel-gfx] [PATCH] drm/i915: hangcheck timeout for debugfs

2011-06-25 Thread Chris Wilson
On Fri, 24 Jun 2011 08:46:53 -0700, Ben Widawsky wrote: > On Fri, Jun 24, 2011 at 12:48:22AM +0100, Chris Wilson wrote: > > On Thu, 23 Jun 2011 15:49:14 -0700, Ben Widawsky wrote: > > > Provide a user accessible way to change the hangcheck timer. This is > > > useful mostly for disabling the time

Re: [Intel-gfx] [PATCH] drm/i915: hangcheck timeout for debugfs

2011-06-24 Thread Ben Widawsky
On Fri, Jun 24, 2011 at 12:48:22AM +0100, Chris Wilson wrote: > On Thu, 23 Jun 2011 15:49:14 -0700, Ben Widawsky wrote: > > Provide a user accessible way to change the hangcheck timer. This is > > useful mostly for disabling the timer completely (value <= 0). > > Having i915.hangcheck_interval as

Re: [Intel-gfx] [PATCH] drm/i915: hangcheck timeout for debugfs

2011-06-23 Thread Chris Wilson
On Thu, 23 Jun 2011 15:49:14 -0700, Ben Widawsky wrote: > Provide a user accessible way to change the hangcheck timer. This is > useful mostly for disabling the timer completely (value <= 0). Having i915.hangcheck_interval as a read/write module parameter was better. :-p -Chris -- Chris Wilson,

[Intel-gfx] [PATCH] drm/i915: hangcheck timeout for debugfs

2011-06-23 Thread Ben Widawsky
Provide a user accessible way to change the hangcheck timer. This is useful mostly for disabling the timer completely (value <= 0). Signed-off-by: Ben Widawsky Cc: Keith Packard --- drivers/gpu/drm/i915/i915_debugfs.c | 88 +++ drivers/gpu/drm/i915/i915_dma.c