Re: [Intel-gfx] [PATCH] drm/i915: hangcheck parameter

2011-06-22 Thread Chris Wilson
On Wed, 22 Jun 2011 10:55:33 -0700, Ben Widawsky wrote: > I was planning a debugfs entry for it. Do you see any advantages to > using an IOCTL? The only danger is that we developing a useful api and hiding it debugfs. We may be caught and forced to maintain such even if we do declare it as a work

Re: [Intel-gfx] [PATCH] drm/i915: hangcheck parameter

2011-06-22 Thread Ben Widawsky
On Wed, Jun 22, 2011 at 06:45:56PM +0100, Chris Wilson wrote: > On Wed, 22 Jun 2011 10:32:50 -0700, Ben Widawsky wrote: > > The hangcheck is undesirable when doing shader debugging. The debugger > > interacts with the EU, and these may cause the hangcheck to fire at most > > unfortunate times. > >

Re: [Intel-gfx] [PATCH] drm/i915: hangcheck parameter

2011-06-22 Thread Chris Wilson
On Wed, 22 Jun 2011 10:32:50 -0700, Ben Widawsky wrote: > The hangcheck is undesirable when doing shader debugging. The debugger > interacts with the EU, and these may cause the hangcheck to fire at most > unfortunate times. > > This provides a way to let the user disable the hangcheck when they

[Intel-gfx] [PATCH] drm/i915: hangcheck parameter

2011-06-22 Thread Ben Widawsky
The hangcheck is undesirable when doing shader debugging. The debugger interacts with the EU, and these may cause the hangcheck to fire at most unfortunate times. This provides a way to let the user disable the hangcheck when they want to do shader debugging. Not Signed-off-by, for review only I